fix(git/fetch): report a fetch/skip summary instead of raw errors - #732
Merged
Conversation
A repo the script can't fetch (e.g. no publickey access) already gets skipped via `continue`, but the raw git/ssh failure text printed to the terminal made it look like the whole run had crashed rather than just moving on. Quiet that output and instead read the repo list from a temp file (a plain pipe would have run the loop in a subshell, losing any counters) so the run can report a final summary: how many repos were fetched, how many were skipped, and why.
credfeto
marked this pull request as ready for review
July 26, 2026 22:25
credfeto
enabled auto-merge
July 26, 2026 22:25
credfeto
approved these changes
Jul 26, 2026
Owner
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchscript already skips a repo it can't reach (e.g. no publickey access) viacontinue, but the raw git/ssh failure text printed to the terminal made a normal skip look like a crash./dev/null, keeping the existingwarnmessage as the only output on failure.N repo(s) fetched, M repo(s) skipped) plus the list of skipped repos with reasons.Test plan
shellcheck -s sh git/fetchpasses