Implement close action with v2 hooks using a finalizer#80
Merged
jeremy-clerc merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
Contributor
jeremy-clerc
commented
Mar 3, 2026
jeremy-clerc
commented
- Rename cancel to close as we not canceling preparation, just notifying that the node disruption has ended.
- For each impacted budget of a node disruption we are calling the associated application disruption budget Close hook.
jeremy-clerc
force-pushed
the
close_disruption
branch
from
ac1784a to
dead799
Compare
* Rename cancel to close as we not canceling preparation, just notifying that the node disruption has ended. * For each impacted budget of a node disruption we are calling the associated application disruption budget Close hook.
jeremy-clerc
force-pushed
the
close_disruption
branch
from
dead799 to
662d354
Compare
damsallem
requested changes
Mar 4, 2026
| Preparing bool `json:"preparing"` | ||
| Ok bool `json:"ok"` | ||
| // Preparing is set to true when the application manager started preparation. Value is kept true even when the app is ready. | ||
| Preparing bool `json:"preparing"` |
Contributor
There was a problem hiding this comment.
I wonder if instead of having a boolean, an enum value with 3 state : Preparing / Ready / Closing wouldn't be more suitable.
Ok was legacy, so keeping it for retro-compatibility seems the right thing to do.
| } | ||
|
|
||
| func (r *ApplicationDisruptionBudgetResolver) CallCancelHook(ctx context.Context, nd nodedisruptionv1alpha1.NodeDisruption, timeout time.Duration) error { | ||
| func (r *ApplicationDisruptionBudgetResolver) CallCloseHook(ctx context.Context, nd nodedisruptionv1alpha1.NodeDisruption, timeout time.Duration) error { |
Contributor
There was a problem hiding this comment.
I find "terminate" verb more appropriate than "close" verb to terminate a NodeDisruption (terminate can be related to closing, deletion, cancellation, finish, ...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.