React upgrades#629
Closed
droberts-ctrlo wants to merge 13 commits into
Closed
Conversation
Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build.
…changed Removed cjs from eslint - cjs are used for internal development files, and should never be included
… dev branch Updated files where dev changes weren't included
Updated documentation Fixed formatting and code where this was broken on merge with current dev branch Added fix for error on documentComponent Updated code files with changes as required where they were included in dev Updated file where missing function wasn't included
Updated to use new switch component for fullscreen
Updated formatting as this didn't update on prev commit properly
Fixed cypress tests
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - some comments added.
| event.preventDefault(); | ||
| const formEl = formRef.current.querySelector('form'); | ||
| if (!formEl) { | ||
| console.error('No form element was found!'); |
There was a problem hiding this comment.
Is there a better way of logging errors? I'm open to being corrected.
| @@ -1,4 +1,4 @@ | |||
| import DataTable from 'datatables.net'; | |||
| import DataTable from 'datatables.net-bs4'; | |||
There was a problem hiding this comment.
Assuming this will be updated when BS5 is ready?
| let is_new_row; | ||
| if (!guid && !current_id) { | ||
| guid = crypto.randomUUID(); | ||
| guid = crypto.randomUUID(); // I wonder if we should use UUID module? Crypto is (exceptionally rarely) not available |
There was a problem hiding this comment.
Potentially add this comment to relevant ticket.
| }); | ||
|
|
||
| it('should set multiple key value pairs on the same instance', async () => { | ||
| it('should set multipe key value pairs on the same instance', async () => { |
Contributor
Author
|
This is all broken in the "very" sense of the word - dependencies for JS have split out over the files and different PR's (and I lost track), jest tests are failing (in part because of this), and, all in all, I think I'm going to start this whole PR again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.