fix(Disclosure): hidden content bug#1209
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f44e2e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-638d01b. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Localized styling and mod wiring on Disclosure.Content with no API or auth/data changes.
Overview
Fixes Disclosure.Content panels that could collapse to 0px height when the browser’s
content-visibility: autoskipped layout for the inner panel while the wrapper was animating open.ContentElementnow uses ashownmod to setcontent-visibilitytovisiblewhile the panel is shown (viaDisplayTransition’sisShown), andautootherwise—matching the wrapper’sshownstate instead of leaving the inner panel always onauto. Consumermodsare still merged in.Patch release noted in the changeset for
@cube-dev/ui-kit.Reviewed by Cursor Bugbot for commit f44e2e1. Bugbot is set up for automated code reviews on this repo. Configure here.