docs: update MCP server deployment & agent selection#11115
Conversation
|
Claude finished @keydunov's task in 1m 22s —— View job Review: MCP server deployment & agent selection docsVerdict: content accurately reflects the new deployment-access model and is well-structured. One pre-existing rendering bug worth fixing while you're in the file, plus a few small polish items posted inline. Findings — 0 high, 1 medium, 4 lowTasks
Inline comments posted
Things that look good
Out of scope
|
| <Steps> | ||
| <Step title="Connect"> | ||
| Complete the OAuth flow. The session is scoped to the tenant default deployment (or | ||
| the first one you can access). | ||
| </Step> | ||
| <Step title="Discover"> | ||
| Call `listDeployments` to see the available `deploymentId` / `agentId` values. | ||
| </Step> | ||
| <Step title="Chat"> | ||
| Call `chat` with your `input`, optionally passing `deploymentId` and/or `agentId` to | ||
| target a specific deployment or agent. Omit both to use the session default deployment | ||
| with its Auto agent. | ||
| </Step> | ||
| </Steps> |
There was a problem hiding this comment.
Minor: the prose introduces three tools (listDeployments, chat, loadQueryResults) but the <Steps> workflow only covers the first two. A reader skimming Steps as the canonical workflow won't see where loadQueryResults fits. Either add a fourth Step for pagination, or note in the bullet that loadQueryResults is called only when a chat response is truncated — so it's clear it isn't part of the normal flow.
| - **`chat`** — accepts two optional selection parameters: | ||
| - **`deploymentId`** — the deployment to use for this request. When omitted, the chat | ||
| uses the deployment from the current session (the default resolved at connect time). | ||
| - **`agentId`** — the agent to use for this request. When omitted or `null`, the |
There was a problem hiding this comment.
Nit: "When omitted or null" — worth double-checking against packages/ai-engineer/src/mcp-server.ts whether MCP clients can actually pass null for agentId, or whether only omission produces Auto. If the JSON schema marks it optional but not nullable, "or null" is misleading. (The PR description says this was verified — leaving as a callout to confirm.)
| #### Authentication and usage flow: | ||
|
|
||
| 1. Run the command copied from **Admin → MCP → Claude → Claude Code**. | ||
| 1. Run the command copied from **Admin → MCP Server → AI Clients → Claude Code**. |
There was a problem hiding this comment.
Pre-existing numbering bug worth fixing while you're touching this block: the steps in this list go 1, 2, 3, 2, 3, 4 (lines 75–80) — the second "2." and "3." restart the count. Markdown will renumber on render, but the source is confusing.
| 1. Run the command copied from **Admin → MCP Server → AI Clients → Claude Code**. | |
| 1. Run the command copied from **Admin → MCP Server → AI Clients → Claude Code**. |
…and renumber the following lines 2.–6. to match.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @keydunov's task in 1m 8s —— View job Review: MCP server deployment & agent selection docs (sync)Verdict: new commit Findings — 0 high, 1 medium, 2 low (+ 1 unposted nit)Tasks
Status of prior threads
Other observations on the new commit
Re-affirmed 3 prior threads still apply; not re-posting to avoid duplicates. |
Replace the obsolete "MCP Defaults" model (default deployment + agent) with the Deployment Access controls (default deployment + allow-list) and document per-request deployment/agent selection via listDeployments and the chat tool's deploymentId/agentId parameters. Refresh admin paths to Admin → MCP Server, add the 403 allow-list troubleshooting case, and flag the stale screenshot. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Commit the MCP Server Deployment Access screenshot as a static asset under docs-mintlify/images/ and reference it in place of the placeholder. Switch the plan-availability callout from Info to the blue Note style. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
69c06f5 to
b037d2f
Compare
|
Claude finished @keydunov's task in 50s —— View job Review: MCP server deployment & agent selection docs (re-sync)Verdict: no new commits since the previous sync — HEAD is still Findings — 0 high, 1 medium, 2 low (re-affirmed)Tasks
Status of prior threads
Re-affirmed 3 prior threads still apply; not re-posting to avoid duplicates. |
Remove the preview warning and replace it with the standard plan-availability note (Premium and Enterprise plans). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Claude finished @keydunov's task in 34s —— View job Review: MCP server deployment & agent selection docs (re-sync)Verdict: new commit Findings — 0 high, 1 medium, 2 low (re-affirmed)Tasks
New commit
Status of prior threads on
Re-affirmed 3 prior threads still apply; not re-posting to avoid duplicates. |
Summary
Updates the inbound MCP server docs (
docs/integrations/mcp-server.mdx) to match the deployment default / allow-list work that shipped in cubejs-enterprise (PR #12596). The old "MCP Defaults" model (a single default deployment + default agent set by admins) no longer reflects the product.Changes
Admin → MCP Server → Deployment Access): default deployment (incl. "Automatic"), the "Limit available deployments" switch, and the available-deployments picker; note that access is intersected with role-based permissions.listDeployments(Auto agent =agentId: null), thechattool's optionaldeploymentId/agentIdwith session-default fallback,loadQueryResults, a Steps workflow, and 403 allow-list enforcement.403 Deployment <id> is not available via MCP for this accountcase.{/* TODO: screenshot */}placeholder for the new Deployment Access section.All behavior verified against the merged enterprise code (
packages/ai-engineer/src/mcp-server.ts,McpEmbedSessionService,McpOAuthService,McpDeploymentAccessSettings.tsx).Follow-up
🤖 Generated with Claude Code