docs(workbooks): document table chart vertical alignment for cell values - #11447
docs(workbooks): document table chart vertical alignment for cell values#11447igorlukanin wants to merge 1 commit into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @igorlukanin's task in 59s —— View job Review complete — docs-only change, looks good. 0 high, 0 medium, 2 low (both inline).Details
AssessmentDocs-only, 4 added lines to Content-wise it's accurate and well-scoped — it documents the feature in both places the page already covers alignment (per-column table at line 37, formatting toolbar at line 208), states the default (middle), and notes that per-column overrides table-wide. Findings (both low, both inline)
Neither blocks merge — the second is purely editorial, and the first is a one-sentence clarification worth making since it's the thing a reader hunting for the control will trip over. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Claude finished @igorlukanin's task in 50s —— View job Re-review after
|
| # | Location | Status | Issue |
|---|---|---|---|
| 1 | table.mdx:213 |
open (marked outdated by GitHub only because line numbers shifted) | "only becomes visible" is ambiguous (control vs. effect), and the paragraph points at Word wrap (per-column, line 38) while sitting in the section whose control is Overflow (line 209). |
| 2 | table.mdx:208 |
open | The single-line rationale lands twice (bullet + line 213), and the color sentence at 211 sits between the bullet and its explanation. |
One new, non-blocking note: the PR description's test plan still says the wording matches "the default (middle)" — that box is now stale given this commit changes it to top. Worth updating the description so a future reader of the PR history doesn't take the checked box as evidence for the old value.
Nothing here blocks merge: both findings are editorial, and the correctness question (which value is the actual default) has been answered by this commit.
|
Claude finished @igorlukanin's task in 1m 10s —— View job Re-review after
|
| # | Location | Severity | Issue |
|---|---|---|---|
| 1 | table.mdx:211 |
low | "Until you pick one" has a loose antecedent — the nearest candidates in the preceding clause are Overflow and Word wrap, not the alignment value, so it can read as "until you turn on wrapping." Suggested "Until you set a vertical alignment, …" inline. |
Consistency of the rest checks out: the per-column table row at line 37 and the toolbar bullet at line 208 use the same three values in the same order and the same bolded-label style, Values-only scoping is stated once, and the default (top) is stated once rather than in both places.
One stale-metadata note carried over from the last review: the PR description's test plan still says the wording matches "the default (middle)", which 9d66474 changed to top. Worth editing the description so the checked box isn't read later as evidence for the old value.
Nothing blocks merge. Docs-only change in the active Mintlify site, no docs.json update needed (existing page), so the security / performance / test-coverage axes don't apply.
|
Claude finished @igorlukanin's task in 50s —— View job Re-review after
|
| Line | Content |
|---|---|
| 37 | Per-column Vertical alignment row — "Top, middle, or bottom — where the value sits when the row is taller than one line" |
| 208 | Toolbar bullet — "top, middle, or bottom (Values only; headers and totals are always a single line)" |
| 211 | Explanatory paragraph — always-available control, conditional effect, Overflow / Word wrap cross-reference, default (top), per-column override |
Consistency checks pass: same three values in the same order in both places, same bolded-UI-label style as the surrounding page, Values-only scoping and the default each stated exactly once, and the explanation sits directly under the bullet list rather than splitting a bullet from its rationale. Docs-only change in the active Mintlify site (/docs-mintlify, not legacy /docs), existing page so no docs.json update needed — the security, performance, and test-coverage axes don't apply.
One piece of stale metadata (non-blocking, outside the diff)
The PR description's test plan still reads "the default (middle)", which 9d66474 corrected to top. Worth editing the description so the checked box isn't later read as evidence for the old value.
6570638 to
35fa0ec
Compare
|
Claude finished @igorlukanin's task in 35s —— View job Re-review after force-push to
|
| Line | Content |
|---|---|
| 43 | Per-column Vertical alignment row — "Top, middle, or bottom — where the value sits when the row is taller than one line" |
| 218 | Toolbar bullet — "top, middle, or bottom (Values only; headers and totals are always a single line)" |
| 231 | Explanatory paragraph — always-available control, conditional effect, Overflow / Word wrap cross-reference, default (top), per-column override |
Verification
All three earlier threads stay fixed through the squash:
- Control-vs-effect ambiguity — line 231 says the control "is always available, but it only has a visible effect once a row is taller than one line". Explicit.
Word wrapvsOverflow— the same sentence names the section-local Overflow first and the per-column Word wrap as the cross-reference, so it no longer points readers at a different panel than the section describes.- Loose antecedent — "Until you set a vertical alignment, values sit at the top" names the setting rather than leaning on "one".
Consistency checks pass: same three values in the same order in both places, same bolded-UI-label style as the surrounding page, Values-only scoping and the default each stated exactly once. The explanatory paragraph at 231 sits after the <Note> about Values alignment (223–229) rather than immediately under the bullet list — that reads fine, since the horizontal-alignment discussion and its note finish before the vertical one begins, and the color sentence no longer splits a bullet from its rationale.
Docs-only change in the active Mintlify site (/docs-mintlify, not legacy /docs), existing page so no docs.json update is needed — the security, performance, and test-coverage axes don't apply.
One piece of stale metadata (non-blocking, outside the diff)
Carried over from earlier rounds: the PR description's test plan still reads "the default (middle)", which the final text corrects to top. Worth editing the description so the checked box isn't later read as evidence for the old value.
35fa0ec to
9f76c0c
Compare
|
Claude finished @igorlukanin's task in 36s —— View job Re-review after rebase onto
|
| Line | Content |
|---|---|
| 43 | Per-column Vertical alignment row — "Top, middle, or bottom — where the value sits when the row is taller than one line" |
| 232 | Toolbar bullet — "top, middle, or bottom (Values only; headers and totals are always a single line)" |
| 245 | Explanatory paragraph — always-available control, conditional effect, Overflow / Word wrap cross-reference, default (top), per-column override |
Verification
All three earlier findings stay fixed through the rebase:
- Control-vs-effect ambiguity — line 245 says the control "is always available, but it only has a visible effect once a row is taller than one line". Explicit.
Word wrapvsOverflow— the same sentence names the section-local Overflow first, with the per-column Word wrap as the cross-reference, so it no longer sends readers to a different panel than the section describes.- Loose antecedent — "Until you set a vertical alignment, values sit at the top" names the setting rather than leaning on "one".
Consistency checks pass: the same three values in the same order in both places, the same bolded-UI-label style as the surrounding page, and Values-only scoping plus the default each stated exactly once. The new upstream conditional-formatting content doesn't collide with this change — it lives in its own section and doesn't discuss alignment, so nothing needed reconciling.
Docs-only change in the active Mintlify site (/docs-mintlify, not legacy /docs), existing page so no docs.json update is needed — the security, performance, and test-coverage axes don't apply.
One piece of stale metadata (non-blocking, outside the diff)
Carried over from earlier rounds: the PR description's test plan still reads "the default (middle)", which the shipped text corrects to top. Worth editing the description so the checked box isn't later read as evidence for the old value.
1 participant
Summary
Test plan