docs(table): document conditional-formatting indicator icons - #11448
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @igorlukanin's task in 1m 29s —— View job Docs-only change, reads accurately — 0 blocking, 3 medium (terminology, duplicated preset menu, misplaced precedence rule), 2 lowFull review
ScopeOne file, docs only — What's correct
Findings
Details on 1–3 are in inline comments. One caveat on the test plan
I could not independently confirm this. The table visualization's frontend isn't in this repo — grepping for |
|
Claude finished @igorlukanin's task in 1m 36s —— View job Re-review of the new commit — still docs-only and accurate. 0 blocking, 2 medium (both carried over), 2 low. Resolved 1 stale thread of mine.Full review
What changed since my last pass
Anchors still resolve ( Prior threads
New findings
Also noted, not worth a thread: "indicator row" (line 269) replaces "formatting row" as the name for where the dropdown lives, and neither term is introduced anywhere on the page — same underlying gap as the undefined "case". If you address the "case" thread, defining the row alongside it costs one clause. "Standout or not" describing strictly above while the other two say at or above looks deliberate rather than sloppy — flagging only so you can confirm it matches the shipped comparison operators. Same caveat as last timeThe new labels — No icon, Achieved or failed, Above or below, Standout or not, and the |
|
Claude finished @igorlukanin's task in 1m 55s —— View job All 3 prior threads addressed. 0 blocking, 1 medium (3-tier semantics need confirming), 2 low.Full review
Prior threads
All threads were already resolved on GitHub, so nothing to re-affirm or clean up. Also good in this commitLine 300 fixes a pre-existing inconsistency that wasn't in scope. The Type selector was described as Conditional formatting / Color scale, but line 308 (already on master) says "the Scale type is disabled". Renaming to Conditional / Scale makes the two agree. Not mentioned in the PR description — worth a line there since it changes a label a reader might search for. Anchors all resolve: Findings
Not worth threads: line 269 "The menu … creates a ready-made rule" — the menu doesn't create, picking an entry does. And the Indicators bullet (271) is the only group whose members aren't named where they're listed; the link covers it. Same caveat as the previous two passesThe UI labels this commit adds or changes — Add case, Conditional formats, Above threshold, Below threshold, 2-tier traffic light, 3-tier traffic light, Color scales, and the Conditional / Scale selector rename — are not verifiable from this repo. Grepping finds only this |
|
Claude finished @igorlukanin's task in 50s —— View job Both prior threads addressed by
|
| Thread | Status |
|---|---|
| 3-tier traffic light semantics ambiguous | Addressed. Line 272 now reads "green above the threshold, amber exactly at it, red on the rest" — the equality tier is explicit, so it no longer reads as loose phrasing for a two-threshold rule. Parallel with the 2-tier entry's "green at or above the threshold, red on the rest". Resolved. |
| Three-tier example stated twice | Addressed. Line 288 collapses to "a three-tier indicator — arrow up above target, dash within tolerance, arrow down below — takes three cases", and the "add the third case yourself" half moved to line 296 where the two-case preset list actually needs it. Better placement than my suggestion — the caveat now sits next to the presets it qualifies. Resolved. |
Also good: line 269 "Picking an entry from the menu … adds a ready-made rule" fixes the menu-doesn't-create nit I'd noted without a thread.
New finding
| # | Severity | Where | Issue |
|---|---|---|---|
| 1 | Low | line 275 | "Every preset compares against a single threshold, which starts at 0" — the old wording ("Presets that compare against a threshold start it at 0") was self-scoping; the new one is a claim about all three groups listed above it, and the Color scales group has no threshold. Per lines 312–314 those rules anchor at Minimum / Maximum / Midpoint. Suggestion posted inline. |
Anchors all still resolve: #rule-presets → 267, #indicator-icons → 277, #color-scale → 298, #inline-bars → 101, #sparklines → 118.
Same caveat as the previous three passes
Everything this commit pins down — that 3-tier traffic light uses one threshold with an exact-equality middle tier, and that the indicator presets are two-case with a 0 default — is unverifiable from this repo. Grepping finds only this .mdx; the table frontend is closed source and nothing in CI here would catch drift. These rest on your check against presets.ts / colorScalePresets.ts, which the test plan says you did.
|
On the recurring caveat about labels not being verifiable from this repo: I checked every one of them against the frontend this pass, not just the new ones. The |
|
Claude finished @igorlukanin's task in 42s —— View job Last thread addressed by
|
ba8ac60 to
fd65d8c
Compare
|
Claude finished @igorlukanin's task in 43s —— View job Re-review after the force-push — history squashed to one commit, content identical to the state I approved. No findings.
|
fd65d8c to
85e941b
Compare
|
Claude finished @igorlukanin's task in 1m 3s —— View job Re-review after the rebase — content unchanged from the approved state, anchors still resolve. No findings.
|
Summary
Add case,Case,Drag case), and the page previously used "case" as its primary unit without ever introducing it.Add rulepreset menu once, in a new Rule presets section. It has three groups —Indicators,Conditional formats,Color scales— and the middle one was undocumented, so 3-tier traffic light looked as though it had been removed when it is simply a color preset rather than an icon one.Test plan
0threshold default checked againstpresets.tsandcolorScalePresets.ts