docs: dimension links render inline in Workbooks - #11452
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @igorlukanin's task in 1m 58s —— View job Docs review: accurate against the code — 1 broken anchor, 1 stale sibling pageFull review (2 inline comments)
Verified against the code
The Findings
Smaller notes
No security, performance, or test concerns — docs-only change. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Claude finished @igorlukanin's task in 1m 20s —— View job Docs review: both prior findings fixed; new content verified against the code — 0 blocking, 3 nitsFull review
Prior findings — both addressed
Agreed on skipping the version note — inline rendering ships with Workbooks, not a Core runtime version, so a Verified against the code
Anchor check — all resolve: The Nits (non-blocking)
Style matches • branch |
|
Took nits 1 and 2 in |
|
Claude finished @igorlukanin's task in 1m 13s —— View job Docs review (
|
| Nit | Status |
|---|---|
| Empty-URL sentence read as general | ✅ reference/…/dimensions.mdx:474 now says "Rows whose primary link URL resolves to an empty value render the cell as plain text" — no longer collides with the concept page's Null values bullet, which is about the menu |
Concept-page example omitted primary |
✅ docs/…/dimensions.mdx:436 marks the search link primary: true, with a comment explaining what it does. The two pages' examples are now symmetric |
Verified against the code
| Claim | Source | Status |
|---|---|---|
primary: true accepted on a link |
CubeValidator.ts:321 — primary: Joi.boolean().strict() |
✅ |
| At most one primary per dimension | CubeValidator.ts:337-339 — Only one link can be marked as primary |
✅ |
format: { type: link, label: … } |
CubeValidator.ts:116-123 formatAlternatives (type optional, label required) |
✅ |
Object form belongs under string dimensions |
formatSchema is the otherwise branch; time/number have their own schemas |
✅ correctly placed |
Anchors — all resolve: #links (table.mdx:83), #cell-menu (table.mdx:158), #behavior (concept :504), #links (concept :382), #format (reference :262), [ref-workbooks] defined at reference :1362. No inbound links to the old #display-tab-… anchor anywhere in docs-mintlify/.
The http/https/mailto restriction and the Style-tab picker behavior are Workbooks frontend, not present in this repo — taken on trust, as before.
Nit (non-blocking) — one new
Duplicate example. The new format object-form code block (reference/…/dimensions.mdx:277-284) repeats the pre-existing crm_link dimension in the CodeGroup 45 lines below (:327-332, mirrored in the JS tab at :363) — same name, same SQL, same label, only the key order differs. The prose is the real addition here; the block is redundant against docs-mintlify/CLAUDE.md's "say it once". Inline suggestion posted keeping the sentence and pointing at the existing example. Fix this →
Anchor churn from ## Display tab → ## Style tab was already flagged and accepted — internally clean, only external bookmarks land at the top of the page.
Both earlier threads are resolved by the author; nothing to re-affirm. Style matches docs-mintlify/CLAUDE.md: surgical edits to existing pages, screenshot placeholders in the established MDX-comment form, no "Cube Cloud" in newly written prose. Docs-only change — no security, performance, or test concerns.
• branch igor/cub-2253-render-values-as-links-docs •
|
Claude finished @igorlukanin's task in 1m 9s —— View job Docs review (
|
| Claim | Source | Status |
|---|---|---|
primary: true accepted on a link |
CubeValidator.ts:321 — primary: Joi.boolean().strict() |
✅ |
| At most one primary per dimension | CubeValidator.ts:337-339 — Only one link can be marked as primary |
✅ |
format: { type: link, label: … } |
CubeValidator.ts:116-123 formatAlternatives (type optional, label required) |
✅ |
Object form belongs under string dimensions |
formatSchema is the otherwise branch; time/number have their own schemas |
✅ correctly placed |
Anchors and link references — all resolve
| Reference | Target | Status |
|---|---|---|
/reference/data-modeling/dimensions#format (table.mdx:93) |
### \format`at reference:262` |
✅ |
/docs/data-modeling/dimensions#links (table.mdx:90) |
## Links at concept :382 |
✅ |
#cell-menu (table.mdx:92) |
## Cell menu at table.mdx:158 |
✅ |
#behavior (concept :411, :520) |
### Behavior at concept :504 |
✅ |
[ref-workbooks] (3 new uses) |
defined at reference :1353 |
✅ |
/docs/explore-analyze/charts/chart-types/table#links (concept :521) |
### Links at table.mdx:83 |
✅ |
No inbound links to the old #display-tab-… anchor anywhere in docs-mintlify/ (grepped for display-tab — zero matches), so the ## Display tab → ## Style tab rename is internally clean. Already flagged and accepted: external bookmarks land at the top of the page.
The http/https/mailto restriction and the Style-tab picker behavior are Workbooks frontend, not present in this repo — taken on trust, as in the earlier rounds.
Nit (trivial, non-blocking)
The prose writes the object form as format: { type: link, label: … } (:274) while the example it points at spells the keys in the other order — label first, then type (:322-323, mirrored in JS at :358-359). Key order is irrelevant to YAML, but a reader jumping from the sentence to the example matches on shape. Swapping the two lines in the example would make the pair read as the same thing. Not worth a commit on its own.
Threads
All three of my earlier threads are already resolved and outdated — nothing to resolve or re-affirm. No new inline comments; the single remaining nit is too small to warrant one.
Docs-only change — no security, performance, or test concerns. Style matches docs-mintlify/CLAUDE.md: surgical edits to existing pages, no padding, screenshot placeholders in the page's established MDX-comment form, no "Cube Cloud" in newly written prose.
|
Claude finished @igorlukanin's task in 44s —— View job Docs review (
|
| Claim | Source | Status |
|---|---|---|
primary: true accepted on a link |
CubeValidator.ts:321 — primary: Joi.boolean().strict() |
✅ |
| At most one primary per dimension | CubeValidator.ts:337-339 — Only one link can be marked as primary |
✅ |
format: { type: link, label: … } |
CubeValidator.ts:116-123 formatAlternatives / formatSchema (type optional, label required) |
✅ |
Object form belongs under string dimensions |
formatSchema is the otherwise branch; time/number have their own schemas |
✅ correctly placed |
Anchors and link references — all resolve
| Reference | Target | Status |
|---|---|---|
/reference/data-modeling/dimensions#format (table.mdx:93) |
### \format`at reference:262` |
✅ |
/docs/data-modeling/dimensions#links (table.mdx:90) |
## Links at concept :382 |
✅ |
#cell-menu (table.mdx:92) |
## Cell menu at table.mdx:158 |
✅ |
#behavior (concept :411, :520) |
### Behavior at concept :504 |
✅ |
/docs/explore-analyze/charts/chart-types/table#links (concept :521) |
### Links at table.mdx:83 |
✅ |
[ref-workbooks] (3 new uses) |
defined at reference :1353 |
✅ |
The http/https/mailto restriction and the Style-tab picker behavior are Workbooks frontend, not present in this repo — taken on trust, as in earlier rounds.
Threads
All four of my earlier threads are resolved and outdated; nothing to re-affirm and nothing new worth an inline comment. The ## Display tab → ## Style tab anchor rename was flagged and accepted earlier — internally clean (zero display-tab references anywhere in docs-mintlify/); only external bookmarks land at the top of the page.
Style matches docs-mintlify/CLAUDE.md: surgical edits to existing pages, no padding, one canonical example per concept, screenshot placeholders in the page's established MDX-comment form, no "Cube Cloud" in newly written prose. Docs-only change — no security, performance, or test concerns.
Verdict: ready to merge.
• branch igor/cub-2253-render-values-as-links-docs •
…d the link format object form
… the dimensions concept page
…ry in the concept example
b631b18 to
14358c0
Compare
|
Claude finished @igorlukanin's task in 2m 6s —— View job Docs review (
|
| Claim | Source | Status |
|---|---|---|
primary: true accepted on a link |
CubeValidator.ts:321 — primary: Joi.boolean().strict() in LinkItemSchema |
✅ |
| At most one primary per dimension | CubeValidator.ts:337-340 — Only one link can be marked as primary |
✅ |
format: { type: link, label: … } |
CubeValidator.ts:115-123 formatAlternatives (type optional, label required) |
✅ |
Object form belongs under string dimensions |
formatSchema is the otherwise branch; time/number have their own schemas |
✅ correctly placed |
The http/https/mailto restriction, the Style-tab link picker, and the icon-button grouping are Workbooks frontend behavior, not present in this repo — taken on trust, as in earlier rounds.
Anchors and link references — all resolve
| Reference | Target | Status |
|---|---|---|
#inline-links (concept :523) |
### Inline links at table.mdx:99 |
✅ (updated in 14358c0) |
#cell-menu (concept :514, table.mdx:108) |
## Cell menu at table.mdx:174 |
✅ |
/docs/data-modeling/dimensions#links (table.mdx:106) |
## Links at concept :382 |
✅ |
/reference/data-modeling/dimensions#format (table.mdx:109) |
### \format`at reference:262` |
✅ |
#behavior (concept :411, :523) |
### Behavior at concept :504 |
✅ |
#icons (concept :411 row) |
### Icons at concept :477 |
✅ |
The H2 rename Showing columns as bars or sparklines → Showing columns as links, bars, or sparklines changes that section's anchor. Grepped docs-mintlify/ for showing-columns-as — zero inbound references, so internally clean; only external bookmarks land at the top of the page.
Low — the concept page's JS tab wasn't updated alongside the YAML tab
docs/data-modeling/dimensions.mdx:436 adds primary: true (plus an explanatory comment) to the search link in the YAML tab of the <CodeGroup>, but the JavaScript tab of the same example (:455-462) still ends at target: \blank`with noprimary. A reader on the JS tab sees the parameter in the table above and no usage below — the exact asymmetry the earlier round fixed for YAML. One line at :461`:
target: `blank`,
primary: true(Not posted inline — that line falls outside the diff hunks.)
Nits (non-blocking)
- Singular/plural leftover from the two-button era —
table.mdx:93says "The three icon buttons are mutually exclusive with each other: picking one replaces the other." Inline suggestion posted. - Two TODO screenshot forms on the same page —
:97uses the house style fromdocs-mintlify/CLAUDE.md({/* TODO: screenshot — … */}), while:117uses a longer variant with inline authoring instructions. Harmless, but matching:97keeps them greppable.
One leftover I'd leave alone: table.mdx:139 still says "When you switch a column to Sparkline" in the old named-toggle voice. It reads fine as a mode name rather than a button label, so it isn't wrong — just noting it since the surrounding sentences were reworded.
Threads
All three of my earlier threads are resolved and outdated — nothing to resolve or re-affirm.
Docs-only change — no security, performance, or test concerns. Style matches docs-mintlify/CLAUDE.md: surgical edits to existing pages, no padding, one canonical example per concept, no "Cube Cloud" in newly written prose (pre-existing occurrences at concept :409/:438 are outside this diff).
Verdict: ready to merge once the JS tab picks up primary: true.
… display-button wording
|
Claude finished @igorlukanin's task in 1m 3s —— View job Docs review (
|
| Finding | Status |
|---|---|
JS tab of the concept-page links example lacked primary |
✅ docs/data-modeling/dimensions.mdx:463 now has primary: true on the search link, and the explanatory comment was carried over to the JS tab too (:456-457) — the two tabs are now symmetric |
| "picking one replaces the other" (two-button leftover) | ✅ table.mdx:93 now reads "picking one replaces whichever was active" |
| Nit: two TODO-screenshot forms on the page | ✅ :117 now uses the short house form, matching :97 and the pre-existing :70 |
Verified against the code
| Claim | Source | Status |
|---|---|---|
primary: true accepted on a link |
CubeValidator.ts:321 — primary: Joi.boolean().strict() in LinkItemSchema |
✅ |
| At most one primary per dimension | CubeValidator.ts:337-340 — Only one link can be marked as primary |
✅ |
format: { type: link, label: … } |
CubeValidator.ts:115-123 formatAlternatives (type optional, label required) |
✅ |
Object form belongs under string dimensions |
formatSchema is the otherwise branch; time/number have their own schemas |
✅ correctly placed |
The http/https/mailto restriction, the Style-tab link picker, and the icon-button grouping are Workbooks frontend behavior, not present in this repo — taken on trust, as in earlier rounds.
Anchors and link references — all resolve
| Reference | Target | Status |
|---|---|---|
#inline-links (table.mdx:95, concept :526) |
### Inline links at table.mdx:99 |
✅ |
#cell-menu (table.mdx:108, :202, concept :517) |
## Cell menu at table.mdx:174 |
✅ |
/docs/data-modeling/dimensions#links (table.mdx:106) |
## Links at concept :382 |
✅ |
/reference/data-modeling/dimensions#format (table.mdx:109) |
### \format`at reference:262` |
✅ |
#behavior (concept :406, :411, :412) |
### Behavior at concept :507 |
✅ |
#icons (concept :410) |
### Icons at concept :480 |
✅ |
[ref-workbooks] (3 new uses) |
defined at reference :1353 |
✅ |
The H2 rename Showing columns as bars or sparklines → Showing columns as links, bars, or sparklines changes that section's anchor; grepping docs-mintlify/ for showing-columns-as and display-tab returns zero inbound references, so it's internally clean. Already flagged and accepted: external bookmarks land at the top of the page.
One leftover I'd still leave alone
table.mdx:139 — "When you switch a column to Sparkline" is the last sentence in the old named-toggle voice. It reads as a mode name rather than a button label, so it isn't wrong; not worth a commit.
Threads
All four of my earlier threads are resolved and outdated — nothing to resolve or re-affirm, and nothing new worth an inline comment.
Docs-only change — no security, performance, or test concerns. Style matches docs-mintlify/CLAUDE.md: surgical edits to existing pages, no padding, one canonical example per concept, screenshot placeholders in the page's established MDX-comment form, no "Cube Cloud" in newly written prose.
Verdict: ready to merge.
1 participant
Makes two documented promises about dimension links specific and true, now that Workbooks renders them.
links. The page said links "can be rendered as HTML links by supporting tools" without saying what that meant. It now states what actually happens: every link is available from the table cell context menu, and the link markedprimaryalso renders inline on the cell value.primary. The flag was accepted and validated (at most one per dimension) but never documented. It's now described whereiconandtargetare, and shown in the YAML example.format: link. The table entry now says the value itself is used as the URL, and documents the object form —format: { type: link, label: … }— which was already accepted but undocumented. Also notes that values outsidehttp,httpsandmailtorender as plain text.The table chart page's "Links" section described an older flow (picking a hidden URL column as the source) that doesn't match the product; it now describes declaring links in the data model and choosing which one renders.