Skip to content

🎨 Palette: CLI UX Improvements and Input Robustness #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

🎨 Palette: CLI UX Improvements and Input Robustness #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions project/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,16 @@ def main(name: str = "World"):
Args:
name: the name to be greeted
"""
name = name.strip() or "World"

if len(name) > 100:
raise UsageError("Invalid name: maximum length is 100 characters.")
raise UsageError(f"Name too long ({len(name)}/100 characters). Please keep it under 100.")
if any(not c.isprintable() for c in name):
raise UsageError("Invalid name: control characters are not allowed.")

secho(f"Hello {name}! 👋", fg="green", bold=True)
secho("Hello ", nl=False)
secho(name, fg="cyan", bold=True, nl=False)
secho("! 👋", fg="green", bold=True)


if __name__ == "__main__":
Expand Down
2 changes: 1 addition & 1 deletion tests/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def test_name_too_long():
runner = CliRunner()
result = runner.invoke(main, ["--name", "A" * 101])
assert result.exit_code != 0
assert "maximum length is 100 characters" in result.output
assert "Name too long (101/100 characters)" in result.output


def test_name_control_characters():
Expand Down