Update seccomp rules#166
Merged
Merged
Conversation
phip1611
approved these changes
Jun 2, 2026
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Amazing, outstanding, best in class PR 🥳
I have a couple of questions:
- did you check what causes the read() in the event monitor thread?
- did you check if this is also broken on upstream?
Author
|
I only added the seccomp rules, I did no further checks. If we want to do that we should open a ticket for it, because checking what causes the |
Member
To clarify: My question was about a 3 minute quick search with looking at the code, not a deep investigation. |
tpressure
approved these changes
Jun 2, 2026
Coffeeri
approved these changes
Jun 2, 2026
Seccomp violation found in https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/jobs/2109117 On-behalf-of: SAP sebastian.eydam@sap.com Signed-off-by: Sebastian Eydam <sebastian.eydam@cyberus-technology.de>
Seccomp violation found in https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/jobs/2109212 On-behalf-of: SAP sebastian.eydam@sap.com Signed-off-by: Sebastian Eydam <sebastian.eydam@cyberus-technology.de>
amphi
force-pushed
the
update-seccomp-rules
branch
from
b4fe366 to
ff6b179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the seccomp rules for the http-server and the event-monitor. Pipelines that failed because of seccomp violations are linked in the commits.