release: fix vendor.tar.zst generation#402
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Our old pipeline-based compression setup for the vendor tarball would result in a corrupted tar archive (as other commands would output informaiton to stdout that would be captured and prepended to the tar archive contents). The simplest solution is to just two-phase it. We could build-in the compression to the archive step, but arguably doing two-pass compression is slightly better anyway. Fixes: 8b989b3 ("make: add signed release build script") Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
release-vendor-tarball
branch
from
93b6142 to
7668258
Compare
We've just fixed a bug in this, it seems prudent to at least validate that they are sane tar archives. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
release-vendor-tarball
branch
from
20dbccd to
71f2d1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our old pipeline-based compression setup for the vendor tarball would
result in a corrupted tar archive (as other commands would output
informaiton to stdout that would be captured and prepended to the tar
archive contents).
The simplest solution is to just two-phase it. We could build-in the
compression to the archive step, but arguably doing two-pass compression
is slightly better anyway.
Fixes #400
Fixes: 8b989b3 ("make: add signed release build script")
Signed-off-by: Aleksa Sarai cyphar@cyphar.com