chore: resolve shell-quote to 1.8.4 (clears critical CVE)#951
Merged
Conversation
shell-quote <1.8.4 has a critical command-injection advisory (quote() does not escape newlines in object .op values). It reaches us only transitively through react-scripts dev/build tooling: - react-scripts > react-dev-utils > shell-quote - react-scripts > webpack-dev-server > launch-editor > shell-quote Not in the production bundle (webpack-dev-server / react-dev-utils run only during `yarn start`), so not visitor-exploitable. Pinned via resolution anyway to keep the audit clean. In-range patch bump (1.8.3 -> 1.8.4), single copy in the tree. Audit: critical 2 -> 0.
✅ Deploy Preview for tezos-homebase ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A critical advisory landed on
shell-quote<1.8.4 (command injection —quote()does not escape newlines in object.opvalues). It reaches the tree only throughreact-scriptsdev/build tooling:react-scripts > react-dev-utils > shell-quotereact-scripts > webpack-dev-server > launch-editor > shell-quoteThese run only during
yarn start(local dev) — not in the production bundle Netlify ships, so it isn't exploitable by site visitors. Pinned via resolution regardless, to keep the audit clean and the next security report green.In-range patch bump (1.8.3 → 1.8.4), single copy in the tree.
Audit impact
(Both criticals were this same
shell-quoteadvisory via the two paths above.)Test plan
yarn install— clean, singleshell-quote@1.8.4in treenpx tsc --noEmit— greenyarn audit --level critical— 0 criticals