feat(share): briefing copy actions + personalized digest share parity

[tsahimatsliah]

PR 7 of the sharing-visibility initiative. Stacks on PR 1 (#6343) — base is claude/website-sharing-visibility-be6b32, not main.

A presidential briefing is one of the most shareable things daily.dev produces, and there was almost nowhere to share it from: the briefing list had no copy affordance, the header had a single desktop-only copy-link button, the briefing body had none at all, and the personalized digest — which renders the same header component — had nothing whatsoever.

What changed

1. /briefing rows (BriefListItem.tsx) — copy-link and a share arrow at the end of each row.

2. Inside the briefing body (new BriefContent.tsx) — the body is a single sanitized-HTML blob from Markdown, so there was no per-item affordance: the only way to share one finding was to select text by hand. BriefContent wraps Markdown, appends a mount node to every heading, bullet and paragraph, and portals a copy control into it.

A bullet or paragraph copies its own text; a heading copies its whole section — heading, prose, then one bullet per line — stopping at the next heading. The selector is deliberately wide (h1–h4, li, standalone p): the body is model-generated, so heading level and bullets-vs-prose vary between briefings, and matching only h2/h3/li left some briefs with no controls at all. Controls are dimmed at rest and come to full strength on hover or focus — never hover-only, which is undiscoverable on a mouse and unreachable on touch.

3. Post header (BriefPostHeaderActions.tsx) — the same copy + share pair, outside the hidden laptop:block wrapper, since sharing a briefing matters at least as much on mobile. Copy link is its own control rather than living only inside the popover: it is the most common action and should not cost two taps.

4. Digest parity (DigestPostContent.tsx) — it rendered the identical header component with showShareButton omitted, so it had no share affordance. Now passes it, gated. While making it a changed file the strict-typecheck guard surfaced its pre-existing strict-null backlog, fixed by mirroring BriefPostContent. No behaviour change.

Icon language

The share trigger, the copy-link control and the copy-text actions all rendered a copy or link glyph, so "share" and "copy" were indistinguishable. Settled to one glyph per meaning:

Glyph	Means
arrow (ShareIcon)	opens a share surface — popover on desktop, native sheet on mobile. Never a one-tap copy.
link	copies the bare URL
stacked squares (CopyIcon)	copies text, with the link appended
page (DocsIcon)	copies the generated summary

Every text copy appends the briefing link, so a paste into Slack is quotable and still carries attribution.

Copy confirmation

Every control confirms with the design system's success checkmark (VIcon / text-status-success) for 1s, and toasts use ToastType.Success so the chip carries the same check.

New useCopyFeedback hook: useCopy already exposes a copying flag, but there is one per hook instance — the controls inside a briefing share one, so using it directly would light them all at once. The hook tracks which control fired.

Structure

• BriefShareControls.tsx holds the copy + share pair and the standalone copy-link button, used by both the row and the header so the two surfaces cannot drift.
• The row originally grouped its actions behind a dropdown. With no summary that collapsed to two near-identical "copy" entries — more chrome than the controls it hid — so it now shows both directly and the menu component is gone.

Layout fix

base.css sets a global * { flex-shrink: 0 }, so the row's text column kept its w-full width and refused to shrink: the trailing control painted ~100px outside the card border on every row, not just long titles. min-w-0 flex-1 restores a shrinkable basis and the title truncates. Measured 0px overflow at 640/480/360px.

Flag

share_briefing_digest, default false, resolved by useShareBriefingDigest, which also requires the master useSharingVisibility() gate.

Flag-off is identical to PR 1, asserted in Jest: the row renders no interactive controls, the header keeps its legacy copy-link button, the body renders exactly as today, and the digest exposes nothing.

Testing on the preview: both sharing_visibility and share_briefing_digest must be enabled in GrowthBook. With the defaults the preview shows the control experience.

Storybook

stories/components/BriefSharing.stories.tsx — every state of all four surfaces, each in flag-on and flag-off form, plus an Overview mapping them on one page and an IconLanguage story documenting the vocabulary.

Two notes for reviewers:

• useConditionalFeature reads GrowthBook through FeaturesReadyContext + GrowthBookContext. With neither mounted — Storybook's default — every flag resolves to its defaultValue, i.e. off. (The 'control'-returning mock in .storybook/main.ts applies to useFeature, not this path.) A small FeatureGate provider pins flags per story, which the header needs since it reads the gate directly and has no override prop.
• The Toast renderer is mounted in the decorator. Copy actions already toasted through useCopy, but Storybook never rendered it, so the confirmation was invisible there.

OG image — deferred, deliberately

Not shipped. packages/webapp/pages/image-generator/ pages are plain Next.js pages that a backend screenshot service renders and captures. A briefing OG image needs that service taught a new route plus an ISR data path for brief posts — a backend dependency that cannot land from this repo alone.

Verification

• node ./scripts/typecheck-strict-changed.js — passed
• pnpm --filter shared lint — clean
• NODE_ENV=test pnpm --filter shared test — 296 suites / 2004 tests
• NODE_ENV=test pnpm --filter webapp test — 44 suites / 297 tests
• NODE_ENV=test pnpm --filter extension test — 6 suites / 43 tests

Tests cover both copy payloads and the section boundary, the wide selector against an h1/h4 prose-only brief, the nested-paragraph case, the checkmark appearing only on the clicked control and clearing after its window, logging discriminators per item kind, and flag-off rendering nothing.

🤖 Generated with Claude Code

Preview domain

https://claude-share-briefing-digest.preview.app.daily.dev

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
daily-webapp	Ready	Preview	Jul 29, 2026 7:27am
storybook	Building	Preview	Jul 29, 2026 7:27am

[tsahimatsliah]

⚠️ 6cf22f33b must be reverted before merge.

The preview deploy resolves share_briefing_digest to its false default, so none of this PRs surfaces were testable there — isDevelopment is false in a Vercel preview build, so the documented local escape hatch does not reach it. That commit adds a FORCE_ON_FOR_PREVIEW constant in useShareBriefingDigest.ts purely so the preview is reviewable.

The flag default in featureManagement.ts is untouched and stays false. To restore the real gate, delete the constant and its use in the return — nothing else changes.

git revert 6cf22f33b

[tsahimatsliah]

Rebuilt as a single clean commit on top of PR 1. The temporary FORCE_ON_FOR_PREVIEW override is gone — useShareBriefingDigest resolves the real gate again, so there is nothing left to revert before merge.

Consequence for preview testing: sharing_visibility and share_briefing_digest both need enabling in GrowthBook, otherwise the preview shows the control experience.

[tsahimatsliah]

7441c0f68 re-adds the preview override — the /mockup-to-eng pass removed it as scaffolding, which also made the feature invisible on the preview deploy.

It sits in its own commit on top of the feature commit, so git revert 7441c0f68 restores the real gate and leaves 06d90436f untouched. The flag default stays false.

Revert before merge.

[capJavert]

Code review complete. Blocking before merge: useShareBriefingDigest still contains FORCE_ON_FOR_PREVIEW = true, which bypasses both sharing_visibility and share_briefing_digest for every environment. Revert commit 7441c0f68 as documented before this can be approved. I found no merge conflict; the PR is currently clean against its stacked base.

[tsahimatsliah]

@capJavert Fixed in 616015d05 — a straight git revert 7441c0f68.

You were right, and more right than my own commit message was. I labelled it "for preview", but return FORCE_ON_FOR_PREVIEW || (...) has no environment condition in it at all — it short-circuits to true everywhere, so on merge it would have shipped the initiative to 100% of users and made the sharing_visibility kill-switch inert. Not a preview-only hack, a production one.

useShareBriefingDigest is back to:

return isSharingVisible && value;

grep -rn "FORCE_ON_FOR_PREVIEW\|TEMP-REVIEW" across packages/shared, packages/storybook and packages/webapp returns nothing, so no scaffolding is left anywhere.

Why it existed, for context: share_briefing_digest defaults to false, and isDevelopment is false in a Vercel preview build (NODE_ENV is production there), so the documented local escape hatch does not reach the preview — none of the surfaces render there without a GrowthBook override. That is a testing-workflow problem and it should not have been solved in the source. Anyone reviewing the preview now needs sharing_visibility and share_briefing_digest enabled in GrowthBook.

Verified after the revert: shared 296 suites / 2004 tests, webapp 44 / 297, strict typecheck and lint_shared clean.

Two things in this PR that are additive to analytics and worth a heads-up rather than a change:

• ShareProvider.CopyText (copy text) is a new provider value; nothing else emits it
• extra.content (brief_bullet / brief_paragraph / brief_section) is a new key

Existing dashboards will not break, but they will not include these copies until the filters are widened. Happy to rename either if you would prefer they fold into an existing value.

[capJavert]

Re-reviewed after 616015d. The unconditional preview override is fully reverted and both sharing gates are effective again. I found no remaining code blocker. Approved against the stacked base; merge sequencing still depends on #6343.