Expand language-specific circled number support and fix translations#533
Open
moritz-gross wants to merge 1 commit intodaisy:mainfrom
Open
Expand language-specific circled number support and fix translations#533moritz-gross wants to merge 1 commit intodaisy:mainfrom
moritz-gross wants to merge 1 commit intodaisy:mainfrom
Conversation
…across multiple files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses some points from issue #530 which I created based on your comment on the circled numbers.
Some of the points that Cursor most likely pointed out are not applicable as I see it, for example ㉑ and ❶ already exist.
What is not done yet is the numerical range 37-50, so I did that first.
Additionally, there are a few mistakes in the already translate symbols that were found, like "umgekreiste" vs. "umkreiste" in German (which I can validate), as well as simple copy-pasting mistakes for example in Spanish, see the Unicode-ID there too.
I think it makes sense to let Codex/Claude run extensively on all the German stuff that has been done and I'll check the findings.