Skip to content

Echov5 support#959

Open
sharath-09 wants to merge 7 commits into
danielgtaylor:mainfrom
sharath-09:echov5-support
Open

Echov5 support#959
sharath-09 wants to merge 7 commits into
danielgtaylor:mainfrom
sharath-09:echov5-support

Conversation

@sharath-09
Copy link
Copy Markdown

This PR uplifts the humaecho adapter to support the new echov5 standard. Happy to hear feedback. Addresses Issue #957

@sharath-09 sharath-09 mentioned this pull request Feb 11, 2026
@wolveix
Copy link
Copy Markdown
Collaborator

wolveix commented Feb 11, 2026

Hey @sharath-09, thanks for this!

I do have a few notes to clarify; why have you changed the context usage to use pointers when it wasn't necessary or beneficial to do so before? Is this a requirement for v5?

Why rename middlewares to middleware, particularly when it can contain multiple middleware calls?

Additionally, please revert the dependency changes, particularly the upgraded Go version.

@wolveix
Copy link
Copy Markdown
Collaborator

wolveix commented Feb 19, 2026

Hey @sharath-09! Have you had a chance to review my comments? We've updated Huma to use Go 1.25, and have updated all other dependencies :)

@sharath-09
Copy link
Copy Markdown
Author

Hey @wolveix apologies for the delay, life got in the way.

I was initially confused about how to approach the versioning bump, but seems like it's been resolved in #962.

Thanks for the feedback, I have used pointers, as this is a major breaking change introduced in Echov5 - https://github.com/labstack/echo/blob/v5.0.0/API_CHANGES_V5.md. The context returned is a concrete struct rather than an interface.

I have pulled the latest commits, renamed middleware to middlewares, and made sure it passes tests.

Please let me know if you have any additional feedback. If you'd like me to use dedicated files for echov4 as in #962, I can do so. Thanks!

@sharath-09
Copy link
Copy Markdown
Author

@wolveix I have retained Echo v4 support in a separate file, as echo v4 support drops in 31/12/2026. Once this date passes, it should be trivial to drop v4 support.

@sharath-09
Copy link
Copy Markdown
Author

Hey @wolveix Just wanted to check in and see if there's anything blocking this. Thanks

@Achno
Copy link
Copy Markdown

Achno commented May 19, 2026

I'm also interested in this getting merged any updates @wolveix , there a lot of improvements with echov5 and i can't really update if huma doesn't have support.

@wolveix
Copy link
Copy Markdown
Collaborator

wolveix commented May 19, 2026

Hey @sharath-09 and @Achno! Thanks for bumping this. Please resolve the merge conflicts, and I'll do one last pass/test before merging. Thank you!

@sharath-09
Copy link
Copy Markdown
Author

Thanks @wolveix! I've resolved merge conflicts 👍

@wolveix
Copy link
Copy Markdown
Collaborator

wolveix commented May 28, 2026

@sharath-09 seems there are CI issues. Mind taking a look? :D

@ibbycs
Copy link
Copy Markdown

ibbycs commented May 30, 2026

@sharath-09 @wolveix

Didn't see this PR before making my own PR #1034, my bad.

Considering we're keeping the v4 adapter it makes sense to test both adapters in adapters_test.go? Currently it's only testing v5.

@wolveix wolveix mentioned this pull request May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants