bugfix - preserve decorated builtin-name calls in inline tests (#677)#679
Merged
dannymeijer merged 3 commits intoMay 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the remaining decorated builtin-name inline-test regression on the v0.3 release branch and folds in the related runner/codegen hardening found during the review loop. Decorated callables such as a source-level
sum(...)now shadow implicit builtin roots consistently through typechecking and lowering, multi-file inline-test batches preserve per-file scope without splitting harmless repeated imports, and the v0.3 release notes are decomposed into more readable feature and hardening sections.Type of change
docs/RFCs/*)Area(s)
Select the primary areas touched (used for review routing; labels are managed separately):
Key details
Testing / verification
make test/cargo testmake examples(if relevant)incan fmt --check .(if relevant)Manual verification notes:
make pre-commitcargo test local_function_named --features clicargo test test_decorated_function_named_sum_shadows_builtin_sum_in_inline_module_tests --features clicargo test partition_collision_free_file_groups --features clicargo test module_name_for_segments_disambiguates_join_collisions --features clicargo test std_web_prelude_import_snapshot --features cli --test stdlib_generated_rust_snapshot_testscargo test e2e_inline_decorated_sum_shadows_builtin_sum_issue677 --features cli --test integration_testscargo test e2e_conventional_test_batches_split_import_declaration_collisions_issue676 --features cli --test integration_testscargo test e2e_directory_run_preserves_per_file_inline_test_modules_issue676 --features cli --test integration_testscargo test e2e_fixture_lifetime_success_scenarios_share_one_project --features cli --test integration_testscargo test equivalent_helper_backed_keywords_typecheck --features cli --test integration_testscargo run --quiet --features cli --bin incan -- test /private/tmp/incan-677-repro/src/decorated_sum_union.incngit diff --checkDocs impact
If docs updated:
workspaces/docs-site/docs/release_notes/0_3.md,workspaces/docs-site/docs/roadmap.mdChecklist
Closes #677