ci: update sdkdocs codeowners#5165
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5165.westus2.7.azurestaticapps.net |
Signed-off-by: Mike Nguyen <hey@mike.ee>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5165.westus2.7.azurestaticapps.net |
nelson-parente
left a comment
nelson-parente
left a comment
There was a problem hiding this comment.
Pre-review for @marcduiker handoff: LGTM. Adds SDK maintainer teams to CODEOWNERS for /sdkdocs/, enabling cross-SDK sanity checks without gating everything on docs maintainers. The @dapr/approvers-docs and @dapr/maintainers-docs teams remain as co-owners, so the two-approver requirement is preserved. Safe to merge after CI.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5165.westus2.7.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5165.westus2.7.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5165.westus2.7.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5165.westus2.7.azurestaticapps.net |
3 participants
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This adds all SDK maintainers as codeowners for docs. Given the recent-ish migration of SDK docs out of their respective repositories, there has been a removal of the SDK maintainers from the loop which is now gated by docs maintainers.
Following the discussion today about unblocking Docs progress - this was a result of the quick proposal. SDK maintainers are now able to approve docs for other SDKs whereby a sanity-check can be completed so at least two people are required to make changes to
/sdkdocs/.Following this PR, a change should be made to the permissions of the repository so that all maintainers have write access - gated by branch permissions/rulesets ensuring at least one other reviewer which should be in the CODEOWNERS.
Issue reference