[1.18] scheduler/placement: v1.18 tuning defaults#5171
Open
JoshVanL wants to merge 4 commits into
Open
Conversation
Cover two related v1.18 changes: dapr/dapr#9942 retunes the Scheduler's embedded etcd for workflow read/write profile: - etcd-snapshot-count 10000 -> 100000 - etcd-compaction-mode periodic -> revision - etcd-compaction-retention 10m -> 1000000 - etcd-backend-batch-limit 5000 -> 10000 - etcd-backend-batch-interval 50ms -> 100ms - new flag --etcd-max-txn-ops, default 10000 (etcd's own default is 128) - Helm cluster.storageSize default for fresh installs 1Gi -> 16Gi (existing installs keep their PVC size via lookup helper). Signed-off-by: joshvanl <me@joshvanl.dev>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Dapr v1.18 documentation to reflect new default tuning parameters for the Scheduler’s embedded etcd, and includes a small formatting cleanup in the Placement docs.
Changes:
- Update Scheduler embedded etcd flag defaults in docs (batching, compaction, snapshot count) and document the new
--etcd-max-txn-opsflag. - Update the Helm values examples in Scheduler docs to match the new defaults.
- Remove an extra blank line in Placement docs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| daprdocs/content/en/concepts/dapr-services/scheduler.md | Updates documented embedded etcd tuning defaults and Helm values; adds the new --etcd-max-txn-ops flag. |
| daprdocs/content/en/concepts/dapr-services/placement.md | Removes an extraneous blank line before “Related links”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
nelson-parente
left a comment
nelson-parente
left a comment
There was a problem hiding this comment.
Pre-review for @marcduiker handoff: LGTM with nits.
- Scheduler etcd tuning defaults updated accurately: snapshot-count, compaction-mode/retention, batch-limit/interval, new
--etcd-max-txn-opsflag, and HelmstorageSizebump. All values match the linked dapr/dapr#9942. - Nit: the
storageSizedefault change (1Gi → 16Gi) is mentioned in the PR body but isn't reflected in the diff shown — worth confirming that section of the scheduler docs was updated or intentionally omitted. - Minor: deleted trailing blank line in placement.md is cosmetic; harmless.
Nothing blocking — Marc, your call.
Signed-off-by: joshvanl <me@joshvanl.dev>
Contributor
Author
|
@msfussell @nelson-parente @marcduiker please take another look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover two related v1.18 changes:
dapr/dapr#9942 retunes the Scheduler's embedded etcd for workflow read/write profile:
(existing installs keep their PVC size via lookup helper).