gtk4-prep: restore motion events to widgets with motion controllers - #21784
Merged
TurboGit merged 1 commit intoAug 10, 2026
Merged
Conversation
The GTK3 bridge for GtkEventControllerMotion only added the enter/leave event masks to the widget, not the pointer-motion mask. GTK3 event controllers don't request input events from GDK themselves (the motion controller's event mask is 0), so widgets with a motion controller never received motion events over event-box-based child widgets -- e.g. the thumbnail hover handlers, which re-show the block overlay after its timeout, so the culling overlay did not reappear on mouse move (fixes darktable-org#21782). Restore the pointer-motion mask as 5.6 did. The other controller helpers were audited: scroll controllers request their own mask, and click/drag gestures land on drawing-area/event-box widgets that request button events by default. Related: darktable-org#21782 darktable-org#15920 darktable-org#20433
Member
|
Works for me, thanks @Arecsu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21782 — in culling, the rating overlay no longer reappeared when moving the mouse after its timeout; only losing and regaining window focus brought it back.
This was a regression from the event-signal → event-controller conversion (#21659). The GTK3 bridge
dt_gui_connect_motion()added only the enter/leave event masks to the widget, not the pointer-motion mask. GTK3 event controllers don't request input from GDK themselves, so the thumbnail motion handlers never fired over the event-box-based thumb widgets — motion went to the parent layout instead. Enter/leave still worked, which is why moving the pointer out of the window and back in (a crossing) did bring the overlay back.The fix restores the pointer-motion mask on every widget with a motion controller, as 5.6 did. The other controller helpers were checked: scroll controllers request their own mask, and click/drag gestures land on drawing-area/event-box widgets that request button events by default — no other spot needs the same change.
Related: #15920 #20433