RFC: allow per-preference texts for unavailable config params - #21792
Open
da-phil wants to merge 1 commit into
Open
RFC: allow per-preference texts for unavailable config params#21792da-phil wants to merge 1 commit into
da-phil wants to merge 1 commit into
Conversation
Add an optional "unavailable_text" attribute to <dtconfig>. When the entry's capability check fails, its text replaces the generic "not available on this system" tooltip; without it the generic one is kept. Fill it in for all capability-gated entries so they state the actual reason: no OpenCL device, fewer than two OpenCL devices, macOS/Windows only OpenCL platforms, and a build without PortMidi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional "unavailable_text" attribute to
<dtconfig>. When the entry's capability check fails, its text replaces the generic "not available on this system" tooltip. Without it, the generic one is kept.I went ahead and filled in such texts for all capability-gated entries so they state the actual reason.