[maintenance] Remove unused <assert.h> from source files - #21795
Open
victoryforce wants to merge 1 commit into
Open
[maintenance] Remove unused <assert.h> from source files#21795victoryforce wants to merge 1 commit into
victoryforce wants to merge 1 commit into
Conversation
In some cases the source code did use assert(), but later when the call to this function was removed the include was not and it became stale and unused. In other cases the include was not actually used from the very first version of the code. It looks like <assert.h> was sometimes included as a copy-paste of an includes block from some similar code...
victoryforce
added
the
scope: codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the source code did use assert(), but later when the call to this function was removed the include was not and it became stale and unused.
In other cases the include was not actually used from the very first version of the code. It looks like <assert.h> was sometimes included as a copy-paste of an includes block from some similar code...
This PR fixes 67 instances of unnecessary include (plus 1 in the previous PR, so there were 68 in total).