Fix circle start clicks, BP_STOP_OUTSIDE, control box colours#27
Merged
Conversation
Three fixes from Steve Saling feedback: 1. Circle start: clicking outside the circle no longer starts/stops Dasher. dasher_mouse_down now checks LP_START_MODE and returns early in circle_start mode. 2. BP_STOP_OUTSIDE: pointer leave detection now works. Removed coordinate clamping in PointerInput::SetPosition so out-of-bounds positions reach the DefaultFilter. IsPointVisible now checks actual screen bounds instead of always returning true. 3. Control box colours: custom control XML with arbitrary colour indices now gets distinct, readable colours via a 12-colour cycle instead of everything falling to the same default purple-blue. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from Steve Saling feedback:
Circle start: clicking outside the circle no longer starts/stops Dasher. dasher_mouse_down now checks LP_START_MODE and returns early in circle_start mode.
BP_STOP_OUTSIDE: pointer leave detection now works. Removed coordinate clamping in PointerInput::SetPosition so out-of-bounds positions reach the DefaultFilter. IsPointVisible now checks actual screen bounds instead of always returning true.
Control box colours: custom control XML with arbitrary colour indices now gets distinct, readable colours via a 12-colour cycle instead of everything falling to the same default purple-blue.