ENH: testing: support 0-D arrays for rtol and atol#743
Merged
lucascolley merged 6 commits intoMay 17, 2026
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
lucascolley
reviewed
May 16, 2026
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
Nice, feel free to update your PR to SciPy to see what passes/fails with this change.
lucascolley
changed the title
rtol and atol
lucascolley
reviewed
May 16, 2026
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
For the CI failures here, I think we should update as_numpy_array to be a no-op on NumPy scalars.
Member
|
On second thought, seems like we can simplify this by just calling |
lucascolley
reviewed
May 16, 2026
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Contributor
Author
Yeah, that's what I initially suggested. Let's merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here: scipy/scipy#25143 (comment)