Skip to content

BUG: test_dunder_dlpack: accept spec-mandated BufferError for a no-copy cross-device export #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonwolfy wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

BUG: test_dunder_dlpack: accept spec-mandated BufferError for a no-copy cross-device export #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions array_api_tests/test_dlpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,17 @@ def test_dunder_dlpack(x, copy_kw, max_version_kw, dl_device_kw, data):
try:
x.__dlpack__(**copy_kw, **max_version_kw, **dl_device_kw)
# apparently, we cannot do anything with the DLPack capsule from python
except BufferError as exc:
copy = copy_kw["copy"] if copy_kw else None
dl_device = dl_device_kw["dl_device"] if dl_device_kw else None

cross_device = dl_device is not None and dl_device != x.__dlpack_device__()
if copy is False and cross_device:
# a no-copy cross-device transfer must be refused with a BufferError
return

ph.add_note(exc, repro_snippet)
raise
except Exception as exc:
ph.add_note(exc, repro_snippet)
raise
Expand Down
Loading