perf(types-builder): reuse vjsf layout for compiledLayout export#44
Merged
Conversation
A schema exporting both `vjsf` and `compiledLayout` compiled and serialized its layout twice. The vjsf compiler now exposes the serialized compiled layout via compileParts(), so cache it per locale during the vjsf export and reuse it for the compiledLayout export instead of compiling again. Output is byte-identical. Requires @koumoul/vjsf-compiler >=1.5.0 (compileParts); peer dependency bumped.
BatLeDev
marked this pull request as draft
July 2, 2026 09:24
BatLeDev
force-pushed
the
perf-types-builder-reuse-compiled-layout
branch
from
July 2, 2026 09:46
8cc1a84 to
13ad450
Compare
BatLeDev
changed the title
The types-builder peer dependency was raised to ^1.5.0 for `compileParts()`, but the root dev dependency and the lockfile still resolved 1.2.3, so an `npm ci` install made the build fail with `compileParts is not a function`. Regenerates the vjsf test fixture, whose i18n messages changed with the new compiler.
The site-patch fixture now exports compiledLayout alongside vjsf, which exercises the layout reuse path, and a test asserts the emitted compiledLayout is byte-identical to the one embedded in the vjsf component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A schema exporting both
vjsfandcompiledLayoutcompiled and serialized its layout twice. The vjsf compiler already produces the serialized compiled layout, so via its newcompileParts()thevjsfexport caches it per locale and thecompiledLayoutexport reuses it instead of compiling again. Output is byte-identical.Why: on portals
build-typesthe schema that exports both (page-config-simple) was ~half of the remaining build time, and its second compile+serialize was pure duplication (~7s).@koumoul/vjsf-compiler1.5.0 (which addscompileParts) is published, so this no longer waits on anything. The peer dependency oftypes-builder, the root dev dependency and the lockfile are all bumped to it — bumping only the peer dependency leftnpm ciresolving 1.2.3 and the build failing withcompileParts is not a function. The bump also regenerates thevjsf-site-patch.vuefixture, whose i18n messages changed with the new compiler.The reuse path had no coverage, so the
site-patchfixture now exportscompiledLayoutalongsidevjsf, and a test asserts the emittedcompiledLayoutis exactly the layout embedded in the generated vjsf component. Note that this test would also pass onmain: it guards the invariant the reuse relies on, it does not by itself prove the reuse happened.