Add DDO integration test skeleton and EVM wallet funding helper#653
Merged
Add DDO integration test skeleton and EVM wallet funding helper#653
Conversation
- Add FundEVMWallet, GenerateTestKey, AnvilFunderKey helpers to util/testutil for funding test wallets on Anvil forks - Add DDO integration tests for dealpusher: connectivity, wallet funding, ValidateSP contract read against calibnet fork - Add DDO integration test for dealtracker: tracking client connectivity and allocation query against calibnet fork - Full deal-creation test left as TODO pending calibnet SP registration by FF These tests follow the existing PDP tracker integration test pattern (Anvil fork of calibnet, real contract clients).
Anvil uses --block-time 1, so the balance check in the test was racing the miner. Poll for the transaction receipt before returning.
Collaborator
|
ok I see the block-time is annoying for this use case, pushing a fix to automine and manually mine in the shovel tests |
parkan
reviewed
Apr 1, 2026
|
|
||
| // TestIntegration_DDOWalletFunding verifies the testutil wallet funding helper | ||
| // works against an Anvil fork. | ||
| func TestIntegration_DDOWalletFunding(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
this should be under testutil tests probably
parkan
approved these changes
Apr 1, 2026
Collaborator
parkan
left a comment
parkan
left a comment
There was a problem hiding this comment.
minor nit about where the funding test lives otherwise lgtm
parkan
force-pushed
the
feat/ddo-integration-test
branch
from
c44888c to
b4728fa
Compare
parkan
force-pushed
the
feat/ddo-integration-test
branch
from
b4728fa to
329cac5
Compare
Collaborator
|
gotta love non-deterministic behavior on GH test runners, the tx is supposed to be synchronous but alas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FundEVMWallet,GenerateTestKey,AnvilFunderKeyhelpers toutil/testutilfor funding test wallets on Anvil forks using the pre-funded account 0dealpusher: connectivity to calibnet fork, wallet funding verification,ValidateSPcontract readdealtracker: tracking client connectivity and allocation queryTests follow the existing PDP tracker integration test pattern (Anvil fork of calibnet, real contract clients). Calibnet DDO contract addresses from ddo-client.
Test plan
go build ./...— compiles cleango vet ./...— no issuesgo test ./util/testutil/... ./service/dealpusher/... ./service/dealtracker/... -short— all pass