Skip to content

fix(appkit): match parameterized raw body paths#394

Open
fallintoplace wants to merge 1 commit into
databricks:mainfrom
fallintoplace:fix/skip-body-parsing-param-routes
Open

fix(appkit): match parameterized raw body paths#394
fallintoplace wants to merge 1 commit into
databricks:mainfrom
fallintoplace:fix/skip-body-parsing-param-routes

Conversation

@fallintoplace
Copy link
Copy Markdown

Summary

  • match skipBodyParsing route templates with :param path segments against real request paths
  • keep exact raw-body path matches as the fast path
  • strengthen server tests so JSON requests prove body parsing is skipped

Root Cause

Plugin routes store raw-body skip paths as full route templates, for example /api/files/:volumeKey/upload. The server JSON parser only compared the runtime request path with exact string equality, so /api/files/uploads/upload did not match the registered template and JSON parsing could consume upload request bodies before the raw stream handler.

Validation

  • pnpm exec vitest run packages/appkit/src/plugins/server/tests/server.test.ts
  • pnpm exec biome check packages/appkit/src/plugins/server/index.ts packages/appkit/src/plugins/server/tests/server.test.ts
  • pnpm --filter @databricks/appkit typecheck
  • git diff --check

@fallintoplace fallintoplace requested a review from a team as a code owner May 19, 2026 18:39
@fallintoplace fallintoplace force-pushed the fix/skip-body-parsing-param-routes branch from b4f5962 to d183349 Compare May 19, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant