bundle migrate: handle added/removed resources gracefully#5463
Open
denik wants to merge 1 commit into
Open
Conversation
Contributor
Approval status: pending
|
Collaborator
|
Commit: f9b0ae3
28 interesting tests: 15 SKIP, 7 KNOWN, 6 flaky
Top 27 slowest tests (at least 2 minutes):
|
1117995 to
fe0d059
Compare
fe0d059 to
b4d3e40
Compare
b4d3e40 to
7bf336c
Compare
7bf336c to
f7c3b39
Compare
f7c3b39 to
f9b0ae3
Compare
Resources in databricks.yml but not in terraform state (added since last deploy) are now skipped during migration and will be created on the first direct deploy, instead of failing the migration. Resources in terraform state but not in databricks.yml (removed since last deploy) now have their ID preserved in the direct state so the next direct deploy will plan and execute deletion, instead of failing the migration. Co-authored-by: Isaac
f9b0ae3 to
bb2f595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Towards auto-migration: we should migrate any situation without errors.
Tests
New acceptance tests.