air run: git-pin code_source snapshots#6016
Open
vinchenzo-db wants to merge 1 commit into
Open
Conversation
Add git pinning to the CLI code_source snapshot path: when code_source.snapshot.git sets a commit or branch, resolve it locally and `git archive` that commit into the tarball (instead of plain-tarring the working tree), then upload it through the same DABs artifact plumbing as the tar path. buildSnapshotTarball now resolves a snapshotPlan (resolveSnapshotPlan) and uses createGitArchiveSnapshot for the git_archive mode. Reintroduces the git helpers (snapshot_git.go, snapshot_resolve.go, snapshot_cachekey.go) removed in the tar PR. Git resolution stays CLI-side (it is a train.yaml construct with no DABs config surface); only the tarball upload reuses DABs plumbing. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 9aeffa9
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 6 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add git pinning to the CLI code_source snapshot path: when code_source.snapshot.git sets a commit or branch, resolve it locally and
git archivethat commit into the tarball (instead of plain-tarring the working tree), then upload it through the same DABs artifact plumbing as the tar path.buildSnapshotTarball now resolves a snapshotPlan (resolveSnapshotPlan) and uses createGitArchiveSnapshot for the git_archive mode. Reintroduces the git helpers (snapshot_git.go, snapshot_resolve.go, snapshot_cachekey.go) removed in the tar PR.
Git resolution stays CLI-side (it is a train.yaml construct with no DABs config surface); only the tarball upload reuses DABs plumbing.
Co-authored-by: Isaac
Changes
Why
Tests
Before:

After:

Submit:
Before:
After:
Get:
Before:
After: