acc/invariant: match Go panics precisely with '!panic:'#6042
Merged
Conversation
radakam
marked this pull request as ready for review
July 23, 2026 14:08
The invariant scripts guard against panics with contains.py '!panic', which forbids the substring 'panic' anywhere in the output. That false-positives on legitimate content that merely contains the word (e.g. a resource name or a message like 'no panic'). Go's runtime prints panics as 'panic:' with a trailing colon, so match that instead. This only relaxes the guard (any output that passed still passes), while removing the substring-collision risk. Applied to all curated invariant scripts (continue_293, delete_idempotent, destroy_idempotent, no_drift) for consistency.
radakam
force-pushed
the
acc-invariant-panic-matcher
branch
from
July 23, 2026 19:14
6f64452 to
4bee5d3
Compare
Collaborator
Integration test reportCommit: 4bee5d3
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
denik
changed the title
denik
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The invariant scripts guard against crashes with
contains.py '!panic' ..., which fails if the substringpanicappears anywhere in the output. That collides with legitimate content — a fuzzer-generated resource name containingpanic, the built-indatabricks selftest paniccommand, or the CLI's own swallowed-panic messages like... telemetry panicked and was skipped. Go's runtime prints every real crash with apanic:header, so match that instead.Scope
acceptance/bundle/invariant/migrate/scriptalready used'!panic:'; this brings the rest in line:continue_293,delete_idempotent,destroy_idempotent, andno_drift. No recorded outputs change (the guards write to/dev/nullon success), so no golden regeneration is needed.