acc: fix change detection skipping new tests on windows/macOS PRs#6047
Merged
Conversation
The acceptance subset selector runs `git diff --merge-base origin/main` to always run the tests a PR adds/changes on the windows/macOS cells, but the test job's shallow checkout has no origin/main, so the diff failed and the error was swallowed, silently disabling change detection. Fetch origin/main in CI and fail loudly on a failed diff instead.
Do not merge. Modifies selftest/basic/script so its golden comparison fails, to confirm from CI logs that change detection runs this test on the windows/macOS subset cells (not skipped by TESTS_SELECT_SUBSET_PCT).
Collaborator
Integration test reportCommit: cd3252b
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
This reverts commit d2893a0.
denik
enabled auto-merge
July 23, 2026 16:33
t.Fatal on a failed `git diff --merge-base origin/main` broke integration runs (DATABRICKS_TEST_SKIPLOCAL=withchanged) whose checkout has no origin/main. Log a warning and continue instead; the push.yml PR cells still fetch full history so change detection works there.
denik
requested review from
janniklasrose and
pietern
and removed request for
pietern
July 24, 2026 08:45
janniklasrose
approved these changes
Jul 24, 2026
1 task
denik
added a commit
that referenced
this pull request
Jul 24, 2026
Revert the fail-open from #6047 now that every caller (push.yml PR cells and integration runs) fetches origin/main. A failed `git diff --merge-base origin/main` should abort loudly instead of silently disabling change detection and letting new tests skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Subsetting is enabled only on the windows/macOS PR cells (
TESTS_SELECT_SUBSET_PCT). There the subset selector runsgit diff --merge-base origin/mainto always run the tests a PR adds/changes, but the test job's shallow checkout has no origin/main, so the diff failed — and the error was swallowed, silently disabling change detection. New tests then fell through to the seeded hash and got skipped, which is how b82fa5c's invariant tests passed on PR yet failed on the nightly Windows run.Changes
DATABRICKS_TEST_SKIPLOCAL=withchanged) also call this from a checkout without origin/main.