Tag genie ask requests with databricks_cli source and disable viz#6056
Merged
Conversation
`databricks experimental genie ask` now sends a `source: "databricks_cli"` field on the OneChat /responses request so the backend can attribute CLI traffic distinctly (vs webapp/Slack/MCP), and sends `enable_viz: false` because the CLI renders in a terminal that cannot display charts. - GenieRequest gains Source (string) and EnableViz (*bool, so false serializes past omitempty) fields. - BuildRequest sets both unconditionally; neither is user-configurable. - Updates the wire-format test and adds a test pinning both fields.
Collaborator
Integration test reportCommit: 2cec482
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
renaudhartert-db
approved these changes
Jul 24, 2026
renaudhartert-db
enabled auto-merge
July 24, 2026 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-home of #5988 (fork PR by @yansonggao-db) onto an in-repo branch so CI can run; reviewed and approved by @lennartkats-db
Changes
databricks experimental genie asknow sets two fields on the OneChat/responsesrequest it already sends:source: "databricks_cli"so the backend attributes CLI-originated Genie traffic distinctly from webapp/Slack/MCP.enable_viz: falsebecause the CLI renders in a terminal that can't display charts, so it tells the agent to skip visualization tools.Neither is user-configurable;
BuildRequestsets both unconditionally.EnableVizis a*boolsofalseserializes pastomitempty.Why
Backend traffic attribution: OneChat buckets conversations by
source, and CLI traffic currently arrives untagged. Disabling viz avoids the agent emitting chart items the terminal can't render.Tests
go test ./libs/genie/...passes.TestBuildRequest_WireFormatpins the new fields andTestBuildRequest_TagsSourceAndDisablesVizassertssourceandenable_viz:falseare always on the wire.Co-authored-by: Yansong Gao yansong.gao@databricks.com