direct: tolerate DELETING apps at apply-time delete#6061
Open
denik wants to merge 1 commit into
Open
Conversation
IsGone is consulted at plan time, but a saved plan (deploy --plan) records Gone=false if the app was still ACTIVE when planned. If the app enters DELETING before apply -- a concurrent delete, or an interrupted destroy -- apply calls DoDelete on the stale entry and the backend rejects the second delete with 400 BAD_REQUEST. On an otherwise-fatal delete error, re-read the resource and consult IsGone (and IsMissing); treat it as already deleted if so. Applies to both Delete (destroy / delete-by-removal) and Recreate. Detection re-reads rather than matching the error because the backend returns a generic 400 with no distinct SDK sentinel. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 03fc5ef
12 interesting tests: 4 RECOVERED, 4 SKIP, 4 flaky
Top 23 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6045, which consulted the new IsGone hook only at plan time. A saved plan (deploy --plan) records Gone=false if the app was still ACTIVE when planned; if it enters DELETING before apply — a concurrent delete, or an interrupted destroy — apply calls DoDelete on the stale entry and the backend rejects the second delete with 400 BAD_REQUEST.
On an otherwise-fatal delete error, re-read the resource and consult IsGone (and IsMissing); treat it as already deleted if so. Applies to both Delete and Recreate. Detection re-reads rather than matching the error because the backend returns a generic 400 with no distinct SDK sentinel.