Skip to content

ci(warm-deps): fix empty --extras on base matrix legs (#831) #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikrantpuppala merged 1 commit into from
Jul 8, 2026
Merged

ci(warm-deps): fix empty --extras on base matrix legs (#831) #848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/warm-deps-cache.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@ jobs:
python-version: ${{ matrix.python-version }}
# extras="" -> base install (no --extras). Otherwise install exactly
# the one extra this leg targets, matching the PR job's isolation.
install-args: ${{ matrix.extras == '' && '' || format('--extras {0}', matrix.extras) }}
# NB: the non-empty branch must come FIRST — GitHub's `A && B || C`
# treats an empty-string B as falsy and would fall through to C, so
# `extras=='' && '' || format(...)` wrongly yields "--extras " (no
# value) for the base leg. Test for non-empty and default to "".
install-args: ${{ matrix.extras != '' && format('--extras {0}', matrix.extras) || '' }}
# Distinct suffix per leg so setup-poetry's own "venv-*" cache (used by
# same-repo PRs) never collides across dependency-version / extras.
cache-suffix: "warm-${{ matrix.dependency-version }}-${{ matrix.extras || 'base' }}-"
Expand Down
Loading