fix: materialized_view with persist_docs not updating existing comments#1276
Draft
vergenzt wants to merge 2 commits into
Draft
fix: materialized_view with persist_docs not updating existing comments#1276vergenzt wants to merge 2 commits into
vergenzt wants to merge 2 commits into
Conversation
|
This PR has been marked as Stale because it has been open for 180 days with no activity. If you would like the PR to remain open, please remove the stale label or comment on the PR. |
Author
|
Still relevant... just doesn't have tests yet |
sd-db
added
the
needs more info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1275
Description
See thorough writeup in #1275 (comment).
I still need to run/add integration tests - this PR would likely be a good candidate for having some.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.