ci(bots): onboard engineer-bot + reviewer-bot (databricks-bot-engine)#1560
Open
eric-wang-1990 wants to merge 3 commits into
Open
ci(bots): onboard engineer-bot + reviewer-bot (databricks-bot-engine)#1560eric-wang-1990 wants to merge 3 commits into
eric-wang-1990 wants to merge 3 commits into
Conversation
…ine)
Adds the four bot workflows + a .bot/ for the engineer, wiring dbt-databricks to
the generic databricks-bot-engine. INERT until an operator completes .bot/SETUP.md
(two GitHub Apps + secrets + the engineer-bot/review-bot labels).
- .github/workflows/{reviewer-bot,reviewer-bot-followup,engineer-bot,engineer-bot-followup}.yml
— inlined (public repo can't consume the internal engine's composites);
runs-on databricks-protected-runner-group + ./.github/actions/setup-jfrog
(egress-blocked runner → JFrog mirror) + id-token: write; engine installed
pinned-by-SHA via BOT_ENGINE_PAT; claude-agent-sdk/CLI pinned. Fork PRs
excluded; maintainer-only label gates.
- .bot/config.yaml — Python/pytest (flow: bug-fix; self-verify via
`hatch run test:unit`); repo_rules_files: [AGENTS.md] (dbt uses AGENTS.md,
not CLAUDE.md — needs an ENGINE_REF including bot-engine PR #71).
- .bot/prompts/{author_system,author_user,followup_system}.md — dbt-adapter
Python testing discipline.
- .bot/SETUP.md — operator prerequisites incl. the protected-runner-group grant
+ JFrog OIDC trust this public repo needs.
Co-authored-by: Isaac
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — INERT until an operator completes
.bot/SETUP.md. Onboards dbt-databricks to the genericdatabricks-bot-engine(issue→bug-fix + PR review, with follow-up on review threads).What's added
reviewer-bot,reviewer-bot-followup,engineer-bot,engineer-bot-followup). Public repo, so they can't consume the engine's internal composites/reusable workflows — everything is inlined. On thedatabricks-protected-runner-groupwith./.github/actions/setup-jfrog(the protected runner is egress-blocked from public PyPI/npm) +id-token: write. Engine installed pinned by SHA viaBOT_ENGINE_PAT;claude-agent-sdk/CLI pinned. Fork PRs excluded; maintainer-only label gates (engineer-bot,review-bot)..bot/for the engineer — Python/pytest (flow: bug-fix, self-verify viahatch run test:unit; functional/warehouse tests are out of scope for self-verify). Reviewer needs no.bot/prompts (engine-owned).repo_rules_files: [AGENTS.md]— dbt-databricks documents conventions inAGENTS.md, notCLAUDE.md. Uses the new engine knob..bot/SETUP.md— operator prerequisites..bot/SETUP.md): create the two GitHub Apps + store their secrets,BOT_ENGINE_PAT,DATABRICKS_HOST/DATABRICKS_TOKEN, and create theengineer-bot/review-botlabels.databricks/dbt-databricksaccess to thedatabricks-protected-runner-groupand add it to the JFrog OIDC trust. (If unavailable, fall back to a self-hosted runner + direct PyPI and dropsetup-jfrog.)ENGINE_REFmust include bot-engine PR Support Delta constraints #71 (configurablerepo_rules_files). Currently pinned to8abd625as a placeholder — re-pin to a SHA that includes Support Delta constraints #71 before activation, elserepo_rules_filesis ignored and (noCLAUDE.mdhere) no conventions inject.Gates and details in the files; rationale in
.bot/SETUP.md.This pull request and its description were written by Isaac.