Fix SQL Server schema not qualified during table introspection#1402
Open
olexanderos wants to merge 3 commits into
Open
Fix SQL Server schema not qualified during table introspection#1402olexanderos wants to merge 3 commits into
olexanderos wants to merge 3 commits into
Conversation
The mssql ibis backend has no schema kwarg at connect time, so an unqualified table lookup falls back to the login's default schema instead of the one configured in server.schema. This made every check fail with "Could not read model" whenever the contract's tables lived outside the login's default schema. Pass the schema explicitly at read time, mirroring the existing Oracle workaround.
Adds unit tests for _table_database() confirming the mssql backend now qualifies table lookups with server.schema, mirroring the existing Oracle test file's structure.
Records the fix so datacontract/schema qualification for SQL Server is reflected in the changelog for the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mssql ibis backend has no
schemakwarg at connect time, so an unqualified table lookup fell back to the login's default schema instead of the one configured inserver.schemaThis made
datacontract testfail every check with "Could not read model" whenever a SQL Server contract's tables lived outside the login's default schemaExtends
_table_database()to pass the schema explicitly at read time for themssqlbackend, mirroring the existing Oracle workaroundTests pass (
uv run pytest)Code formatted (
uv run ruff check --fix && uv run ruff format)Docs updated (if relevant)CHANGELOG.md entry added