Pin the patched brace-expansion and uuid in the docs site - #1444
Merged
Conversation
npm audit fix could not help: it proposed downgrading @easyops-cn/docusaurus-search-local from 0.55 to 0.26 to satisfy the brace-expansion advisory, which flags every 1.x and 2.x release and is fixed only in 5.0.8. Overriding the transitive dependency keeps the plugin and resolves it. js-yaml and http-proxy-middleware were already at their patched versions, so those alerts were stale. The docs site now audits clean.
📖 Docs previewPreview site: https://brave-water-0cee36e03-1444.westeurope.7.azurestaticapps.net No rendered doc pages changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs site had 8 open Dependabot alerts and
npm auditreported 23 vulnerabilities. It now reports 0.Two
overridesentries, alongside theserialize-javascriptone already there:Why
npm audit fixwas no helpIt changed nothing at all — no lockfile edit, no diff. Its proposed fix for the high-severity
brace-expansionadvisory was@easyops-cn/docusaurus-search-local@0.26.1, whilepackage.jsonpins^0.55.2: a downgrade across majors of the search plugin, which is worse than the issue it addresses. That is why it was marked breaking and skipped.The advisory itself is unusually broad — it flags
<= 5.0.7, so every 1.x and 2.x release qualifies, and the only patched release is 5.0.8. Overriding the transitive dependency keeps the plugin at 0.55 and resolves it.Half the alerts were already stale
Dependabot listed
js-yamlandhttp-proxy-middleware, but the lockfile already carried exactly the patched versions:Only the last two needed anything.
Verified
npm audit→ found 0 vulnerabilitiesnpm run buildsucceeds; index, imports and reference pages all generatedbuild/search-index.json, which is the thing npm's suggested downgrade would have put at riskScope
Docs site only. None of these packages ship with the Python CLI — they are build-time dependencies of the Docusaurus site, and all four advisories are DoS-class.