feat(add-data): Add modal to import data via file upload - #189
Open
david-bretaud-dev wants to merge 4 commits into
Open
feat(add-data): Add modal to import data via file upload#189david-bretaud-dev wants to merge 4 commits into
david-bretaud-dev wants to merge 4 commits into
Conversation
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-modal-to-import-new-data
branch
from
July 19, 2026 08:23
beffea5 to
04316e3
Compare
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-modal-to-import-new-data
branch
from
July 19, 2026 08:33
04316e3 to
54560ef
Compare
david-bretaud-dev
changed the base branch from
main
to
david-bretaud-dev/refactor-remove-spacing-tokens
July 19, 2026 08:33
david-bretaud-dev
force-pushed
the
david-bretaud-dev/refactor-remove-spacing-tokens
branch
from
July 19, 2026 08:35
cf98511 to
9976ad4
Compare
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-modal-to-import-new-data
branch
from
July 19, 2026 08:35
54560ef to
db3ec55
Compare
arnaudfnr
reviewed
Jul 19, 2026
| // Accepted upload extensions per kind (coordo's file / kobotoolbox loaders). | ||
| // Form data is the multi-sheet KoboToolbox answers workbook (.xlsx). | ||
| export const ACCEPTED_EXTENSIONS_BY_KIND = { | ||
| [RESOURCE_KINDS.ExternalData]: ".csv,.xls,.xlsx", |
Collaborator
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Okay to have a table, but it should be joined as a final string to be injected in the input at the end (this is the API of the html element): https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/file#accept
The accept attribute value is a string that defines the file types the file input should accept. This string is a comma-separated list of unique file type specifiers.
david-bretaud-dev
force-pushed
the
david-bretaud-dev/refactor-remove-spacing-tokens
branch
from
July 25, 2026 17:27
9976ad4 to
be7c6c4
Compare
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-modal-to-import-new-data
branch
from
July 26, 2026 09:49
db3ec55 to
87cfef3
Compare
david-bretaud-dev
changed the base branch from
david-bretaud-dev/refactor-remove-spacing-tokens
to
main
July 26, 2026 09:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights
Demos
UI only
demo-upload-file-data-ui.mp4
Full flow - Form based (internal)
demo-append-data-inventaire-for.mp4
Full flow - External data
demo-append-external-data.mp4