fix: pages 404#1094
Open
ThibaudDauce wants to merge 6 commits into
Open
Conversation
Contributor
|
I'm getting strange stacktraces like and Previous one was : and |
Contributor
Author
|
@nicolaskempf57 Good catch! It's fixed in 038cf96 |
# Conflicts: # app.vue # error.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix the routing after a 404 (two different way, static error and error from useFetch) :
Also fix after landing first on a 404 (for example visiting
/datasets/azerty, the datagouv-components config is broken. You can navigate from the 404 to a dataset page to witness a "metricsApiUrl and apiBase must be configured"