feat(search): restrict org filter to orgs with an API on dataservices…#1106
Open
Samuelfaure wants to merge 1 commit into
Open
feat(search): restrict org filter to orgs with an API on dataservices…#1106Samuelfaure wants to merge 1 commit into
Samuelfaure wants to merge 1 commit into
Conversation
… search Pass dataservices=true to the org suggest endpoint when the active search is the dataservices (API) search, so the organization filter only offers orgs that have at least one API. Implements API2-314 (frontend half).
Samuelfaure
requested review from
ThibaudDauce,
maudetes and
nicolaskempf57
and removed request for
maudetes
Contributor
|
There are also similar discussions for using organization facets here |
Contributor
Author
|
@maudetes Interessant, je vais faire une repasse |
Contributor
Author
|
@maudetes After looking into it, I propose we ship this as-it and switch to facets in a later PR It's too big of a change for the scope of this PR so let's tackle it in a subsequent bigger PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… search
Pass dataservices=true to the org suggest endpoint when the active search is the dataservices (API) search, so the organization filter only offers orgs that have at least one API. Implements API2-314 (frontend half).
fix https://linear.app/pole-api/issue/API2-314/retirer-les-organisations-par-defaut-du-filtre-organisation-lorsque
linked with opendatateam/udata#3804