feat: add topic page#1110
Open
ThibaudDauce wants to merge 3 commits into
Open
Conversation
maudetes
reviewed
Jun 2, 2026
| page_size: datasetsPageSize.value, | ||
| topic: props.topic.id, | ||
| })) | ||
| const { data: datasets } = await useAPI<PaginatedArray<DatasetV2>>('/api/2/datasets/', { query: datasetsQuery }) |
Contributor
There was a problem hiding this comment.
datasets use api/2/ list endopint when reuses use search endpoint? Shouldn't we use the same logic between the two?
We could also use api/2/topics/<topic_id>/elements/?class=<Reuse,Dataset>?
Contributor
Author
There was a problem hiding this comment.
I think TopicElement will give us more information yes. But do we want to use this specific endpoint if we only show the cards?
Will look into why search vs index
Comment on lines
+37
to
+39
| if ('elements' in subject) { | ||
| return subject.page | ||
| } |
Contributor
There was a problem hiding this comment.
I'm unsure about this check. Isn't the following condition enough?
Contributor
Author
There was a problem hiding this comment.
Yes it's enough when the udata PR is merged. It's only required to test right now.
maudetes
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.