Skip to content

enh: sanbox variants#6

Merged
echarles merged 8 commits into
mainfrom
enh/sandbox-variants
Jul 24, 2026
Merged

enh: sanbox variants#6
echarles merged 8 commits into
mainfrom
enh/sandbox-variants

Conversation

@echarles

@echarles echarles commented Jul 23, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 23, 2026 18:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documented/expected sandbox_variant values to align with the expanded Code Sandboxes variants and bumps the library version.

Changes:

  • Document the supported sandbox_variant options across README and docs (eval/monty/docker/jupyter/colab/modal/datalayer).
  • Update executor sandbox timeout logic to key off sandbox_variant="datalayer" (300s) vs others (30s).
  • Bump package version to 0.1.4.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Expands sandbox_variant docs to list supported variants.
docs/docs/programmatic-tools/index.mdx Updates examples and documents sandbox variants; needs fixes for invalid config param.
docs/docs/integrations/index.mdx Updates examples to new variant names; needs fixes for invalid config param.
agent_codemode/types.py Clarifies sandbox_variant documentation and lists supported variants.
agent_codemode/composition/executor.py Adjusts datalayer timeout logic to match the new variant name.
agent_codemode/version.py Bumps version to 0.1.4.
Comments suppressed due to low confidence (3)

docs/docs/programmatic-tools/index.mdx:250

  • The example passes default_timeout to CodeModeConfig, but CodeModeConfig forbids unknown fields (extra="forbid") and does not define default_timeout, so this snippet will raise a validation error. Consider removing it and passing a timeout to executor.execute(..., timeout=...) instead.

This issue also appears on line 257 of the same file.

config = CodeModeConfig(
    sandbox_variant="eval",            # eval | monty | docker | jupyter | colab | modal | datalayer
    workspace_path="/workspace",       # Working directory
    generated_path="/tmp/generated",   # Where to put generated bindings
    default_timeout=30.0,              # Default execution timeout
)

docs/docs/integrations/index.mdx:316

  • This CodeModeConfig example includes default_timeout, but CodeModeConfig does not accept that parameter (and forbids extras), so the snippet will raise a validation error. Remove it and pass the timeout to the execution call instead.
config = CodeModeConfig(
    sandbox_variant="datalayer",  # Isolated cloud sandbox
    default_timeout=30.0,                  # Limit execution time
    workspace_path="/safe/workspace",      # Restricted workspace
)

docs/docs/programmatic-tools/index.mdx:257

  • This section describes the sandbox as “isolated”, but the eval variant is explicitly “in-process” (no separate process/container), so it isn’t isolated in the usual OS/container sense. Clarify this to avoid over-promising safety/isolation for the default configuration.
- **eval**: In-process Python execution on the same machine (default)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/docs/integrations/index.mdx
@echarles
echarles merged commit 6a21439 into main Jul 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants