fix: spawn whisper-server on the host:port sttUrl points at - #154
Open
nixfred wants to merge 1 commit into
Open
Conversation
WHAT: derive the whisper supervisor's bind host/port from the configured sttUrl setting instead of the hardcoded 127.0.0.1:8080 default. WHY: the onboarding wizard and Settings let users point sttUrl anywhere, but the spawner ignored it and always bound :8080. On any machine where something else owns 8080 (nginx, dev servers, other tools), the wizard's whisper test fails with a confusing 404/health error and the transcribe stage can never start its server. The stt HTTP client already targets sttUrl, so client and spawner now agree by construction. TESTED: 13/13 whisper supervisor tests pass; full suite 673/673; verified live on a machine with nginx on 8080 — app spawned whisper-server on 8090 and transcribed successfully. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fx2epy4XwaBS3S8Y5J7FX9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The onboarding wizard and Settings let users change
sttUrl, but the whisper supervisor is created without a port option, so it always spawnswhisper-serveron the hardcoded127.0.0.1:8080. On machines where something else already owns 8080 (nginx in my case), the wizard's transcription test fails with a confusingHTTP 404 from /health(whatever is squatting the port answers), and the transcribe stage can never start its own server.Fix
Derive the spawner's host/port from the same
sttUrlsetting the stt HTTP client already uses, so client and server agree by construction:WhisperSupervisorOptsalready acceptshost/port, so this is wiring, not new surface. Default behavior (no custom sttUrl) is unchanged.Testing
sttUrltohttp://127.0.0.1:8090, app spawned whisper-server on 8090 and transcribed end to end (large-v3-turbo, macOS 26 / M4 Max).Love the app, by the way — fully local meeting notes with the process-tap capture is exactly the right architecture. This came out of a real deploy tonight.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Fx2epy4XwaBS3S8Y5J7FX9