Fix stream volume commands ignored at boot - #160
Open
dogruis wants to merge 1 commit into
Open
Conversation
init_volume_state_tracker initialised state_volume_muted to 0x0f. The mute gate in stream_volume_down and stream_volume_up skips when it is non-zero, so the music level could not change until an explicit volume_unmute. Initialise it to 0 so volume control works from boot.
Contributor
Author
|
Am I supposed to send a volume_unmute command at boot? Which would invalidate this mr. But What I find frustrating is that we create a flag that doesn't store the right value. It says it is muted by default when it is not! |
dogruis
commented
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init_volume_state_tracker initialised state_volume_muted to 0x0f. The mute gate in stream_volume_down and stream_volume_up returns early when it is non-zero, so the music level cannot change until an explicit volume_unmute. This initialises it to 0 so volume control works from boot.