Suppress remaining Clang warnings on macOS, triggered by gtest-printers.h.#164
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate remaining Clang warning noise on macOS attributed to GoogleTest headers by centralizing warning suppression in Bazel configuration and removing redundant per-target copts entries in test BUILD files.
Changes:
- Adds a test-only warning suppression flag in
.bazelrcto quiet-Wcharacter-conversionfrom GoogleTest headers. - Removes redundant/over-specified
coptssettings from severalcc_testtargets. - Introduces a
DDS_TEST_CPPOPTSalias inCPPVARIABLES.bzl(currently identical toDDS_CPPOPTS).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
library/tests/system/BUILD.bazel |
Removes redundant empty copts attributes from multiple system tests. |
library/tests/moves/BUILD.bazel |
Removes per-target -std=c++20 in favor of global/toolchain configuration. |
CPPVARIABLES.bzl |
Adds a DDS_TEST_CPPOPTS alias/comment intended for test compilation flags. |
.bazelrc |
Adds test-only warning suppression flags for macOS and Linux test runs. |
Use GCC-compatible -Wno-conversion instead of Clang’s -Wcharacter-conversion, per Copilot suggestion. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Copilot suggestions incorporated. Ready for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.