fix(vm): livemigration force handling for PreferForced/AlwaysForced#2179
Open
fix(vm): livemigration force handling for PreferForced/AlwaysForced#2179
Conversation
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes live migration force handling in CLI and controller policy evaluation.
Why do we need it, and what problem does it solve?
d8 v evictandd8 v migratealways sentspec.force=falseby default.Because of that,
PreferForcedwas effectively overridden toallowAutoConverge=false, so migrations were running without throttling even when policy expected forced convergence.Also, for
AlwaysForcedwe keep strict rejection only for explicitforce=false, whileforce=nilfollows policy defaults.What is the expected result?
spec.liveMigrationPolicy: PreferForced.d8 v evict <vm>(without--force).spec.forceunset (nil).allowAutoConverge=true.AlwaysForced:force=nil-> validforce=true-> validforce=false-> rejectedChecklist
Changelog entries