chore(api): remove deprecated VirtualMachineRestore resource#2368
Open
hardcoretime wants to merge 1 commit into
Open
chore(api): remove deprecated VirtualMachineRestore resource#2368hardcoretime wants to merge 1 commit into
hardcoretime wants to merge 1 commit into
Conversation
The VirtualMachineRestore resource is deprecated and should be fully removed. Use VirtualMachineOperation with type Restore/Clone instead. This commit removes: - The vmrestore controller and all its internal components - The VirtualMachineRestore API type and CRD - Related indexers, webhooks, and annotations Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
hardcoretime
requested review from
Isteb4k,
fl64,
goganat,
prismagod and
yaroslavborbat
as code owners
Contributor
|
Workflow has started. The target step completed with status: failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the deprecated
VirtualMachineRestore(vmrestore) resource and its controller from the virtualization module.The following components have been removed:
The common types
NameReplacementandNameReplacementFromwere moved to a separate file as they are still used byVirtualMachineOperation.Why do we need it, and what problem does it solve?
The
VirtualMachineRestoreresource was marked as deprecated. Users should useVirtualMachineOperationwith typeRestoreorCloneinstead. This commit completely removes the deprecated resource to clean up the codebase.What is the expected result?
The
VirtualMachineRestoreresource is no longer available in the API. Users must useVirtualMachineOperationfor restore operations.Checklist
Changelog entries