Skip to content

Fix GPU validation authorization and accounting retries - #7732

Merged
mohanchen merged 2 commits into
deepmodeling:developfrom
Stardust0831:fix/gpu-ci-triage-permission
Aug 1, 2026
Merged

Fix GPU validation authorization and accounting retries#7732
mohanchen merged 2 commits into
deepmodeling:developfrom
Stardust0831:fix/gpu-ci-triage-permission

Conversation

@Stardust0831

@Stardust0831 Stardust0831 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

This is a small follow-up to #7665.

  • Allow collaborators with repository role_name: triage to trigger GPU validation with /abacus-ci gpu, while ordinary Read users remain unauthorized. GitHub reports the Triage role as legacy permission: read, so authorization must also inspect role_name.
  • Retry transient sacct failures while collecting completed Slurm job states. The retry is bounded like the existing squeue handling and only repeats the read-only accounting query; it does not resubmit or rerun jobs.

GitHub repository permissions reference: https://docs.github.com/en/rest/collaborators/collaborators#get-repository-permissions-for-a-user

Testing

  • python3 .ci/slurm/test_runner.py (40 tests)

@Critsium-xy

Copy link
Copy Markdown
Collaborator

/abacus-ci gpu

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

GPU validation: failure

GPU cases: ? passed, ? failed, ? infrastructure.

Open the Actions run | Download raw test files

Candidate: 018f3f4750d792861232d723560d8546bea7d026

@Critsium-xy

Copy link
Copy Markdown
Collaborator

/abacus-ci gpu

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

GPU validation: failure

GPU cases: ? passed, ? failed, ? infrastructure.

Open the Actions run | Download raw test files

Candidate: 018f3f4750d792861232d723560d8546bea7d026

@Critsium-xy

Copy link
Copy Markdown
Collaborator

/abacus-ci gpu

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

GPU validation: success

GPU cases: 49 passed, 0 failed, 0 infrastructure.

Open the Actions run | Download raw test files

Candidate: 018f3f4750d792861232d723560d8546bea7d026

@mohanchen mohanchen added GPU & DCU & HPC GPU and DCU and HPC related any issues Tests/Examples Issues/PR related to unit tests and integrate tests labels Jul 31, 2026
@Stardust0831 Stardust0831 changed the title Fix Triage authorization for GPU validation Fix GPU validation authorization and accounting retries Jul 31, 2026
@mohanchen

Copy link
Copy Markdown
Collaborator

Nice feature, thanks!

@mohanchen
mohanchen merged commit d91ae4c into deepmodeling:develop Aug 1, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GPU & DCU & HPC GPU and DCU and HPC related any issues Tests/Examples Issues/PR related to unit tests and integrate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants