Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 27. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
anakin87
commented
Jun 18, 2026
sjrl
reviewed
Jun 19, 2026
sjrl
reviewed
Jun 19, 2026
sjrl
reviewed
Jun 19, 2026
sjrl
reviewed
Jun 19, 2026
sjrl
reviewed
Jun 19, 2026
sjrl
reviewed
Jun 19, 2026
sjrl
reviewed
Jun 19, 2026
sjrl
approved these changes
Jun 19, 2026
sjrl
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Would be nice if @mpangrazzi could also give it a lookover before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Discussed in https://github.com/deepset-ai/haystack-private/issues/384#issuecomment-4740431488
How did you test it?
Notes for the reviewer
This PR is big. I created a single one to test everything.
Once we agree on the general approach, I'd be happy to split it into smaller parts if you prefer.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.